Register `jakarta.json.spi.JsonProvider` service provider #44649

zakkak · 2024-11-22T15:36:31Z

META-INF/services/jakarta.json.spi.JsonProvider is accessed as a
resource by SmallRyeHealthReporter.

Relates to #41995

gsmet

Hmmm, shouldn't this be handled by the quarkus-jsonp extension?

gsmet · 2024-11-22T20:57:33Z

Yeah my guess is that it should be added here instead: https://github.com/quarkusio/quarkus/blob/main/extensions/jsonp/deployment/src/main/java/io/quarkus/jsonp/deployment/JsonpProcessor.java .

zakkak · 2024-11-25T09:12:55Z

@gsmet this doesn't seem right to me.

quarkus-smallrye-health doesn't depend on quarkus-jsonp:

[INFO] +- io.quarkus:quarkus-smallrye-health:jar:999-SNAPSHOT:compile
[INFO] |  +- io.smallrye:smallrye-health:jar:4.1.0:compile
[INFO] |  |  +- org.eclipse.microprofile.health:microprofile-health-api:jar:4.0.1:compile
[INFO] |  |  +- io.smallrye:smallrye-health-api:jar:4.1.0:compile
[INFO] |  |  \- jakarta.json:jakarta.json-api:jar:2.1.3:compile
[INFO] |  \- io.smallrye:smallrye-health-provided-checks:jar:4.1.0:compile

So if I move the registration there it's not guaranteed to happen every time SmallRyeHealthReporter, i.e. smallrye-health, is used.

gsmet · 2024-11-25T13:14:53Z

Are you sure? Because this output can be misleading: it will only display the dependency if not displayed earlier.

I actually checked that it was the case before posting the other day and we have:

quarkus/extensions/smallrye-health/runtime/pom.xml

Lines 39 to 42 in 9361824

    
           <dependency> 
        
               <groupId>io.quarkus</groupId> 
        
               <artifactId>quarkus-jsonp</artifactId> 
        
           </dependency>

and

quarkus/extensions/smallrye-health/deployment/pom.xml

Lines 28 to 31 in 9361824

    
           <dependency> 
        
               <groupId>io.quarkus</groupId> 
        
               <artifactId>quarkus-jsonp-deployment</artifactId> 
        
           </dependency>

zakkak · 2024-11-25T13:16:38Z

Are you sure? Because this output can be misleading: it will only display the dependency if not displayed earlier.

Hmm I didn't know about that. Thanks!

In that case you are right. Moving it.

gsmet · 2024-11-25T13:18:02Z

Yeah I never completely figured out the rules of dependency:tree but it's really confusing.

Could you try with ./mvnw quarkus:dependency-tree if things are better?

zakkak · 2024-11-25T13:35:57Z

Could you try with ./mvnw quarkus:dependency-tree if things are better?

Nope, still doesn't show up.

[INFO] ├─ io.quarkus:quarkus-smallrye-health-deployment:999-SNAPSHOT (compile)
[INFO] │  ├─ io.quarkus:quarkus-smallrye-health-spi:999-SNAPSHOT (compile)
[INFO] │  ├─ io.quarkus:quarkus-smallrye-health:999-SNAPSHOT (compile)
[INFO] │  │  ├─ io.smallrye:smallrye-health:4.1.0 (compile)
[INFO] │  │  │  ├─ org.eclipse.microprofile.health:microprofile-health-api:4.0.1 (compile)
[INFO] │  │  │  ├─ io.smallrye:smallrye-health-api:4.1.0 (compile)
[INFO] │  │  │  └─ jakarta.json:jakarta.json-api:2.1.3 (compile)
[INFO] │  │  └─ io.smallrye:smallrye-health-provided-checks:4.1.0 (compile)
[INFO] │  └─ io.smallrye:smallrye-health-ui:4.1.0 (compile)

gsmet · 2024-11-25T15:28:23Z

OK, I'm pretty sure it's just an artifact of the tools so please add it to quarkus-jsonp-deployment and if it doesn't fix your issue we can discuss it further.

zakkak · 2024-11-25T15:52:23Z

Done

gsmet

Let's clarify my question before merging (you might have a good reason to use this particular build item).

Also could you please update the title of the PR?

gsmet · 2024-11-26T09:20:15Z

extensions/jsonp/deployment/src/main/java/io/quarkus/jsonp/deployment/JsonpProcessor.java

        reflectiveClass.produce(
                ReflectiveClassBuildItem.builder(JsonProviderImpl.class.getName()).build());
+
+        // Register META-INF/services/jakarta.json.spi.JsonProvider as a resource, accessed by SmallRyeHealthReporter
+        serviceProviders.produce(new NativeImageResourceBuildItem("META-INF/services/jakarta.json.spi.JsonProvider"));


Sorry I missed that earlier but is there a reason why you don't use ServiceProviderBuildItem? It seems more appropriate?

Good point, a ServiceProviderBuildItem without any providers just the job and seems more appropriate.

Thanks Guillaume!

extensions/jsonp/deployment/src/main/java/io/quarkus/jsonp/deployment/JsonpProcessor.java

Register jakarta.json.spi.JsonProvider as a service provider so that both the service file and the implementations are included. Co-authored-by: Guillaume Smet <[email protected]>

gsmet · 2024-11-26T18:40:00Z

Actually, we did it entirely wrong from the start (and I mean when we created the extension). I fixed it by amending your commit. Things should be fine from all point of view now.

zakkak · 2024-11-26T21:24:04Z

Actually, we did it entirely wrong from the start (and I mean when we created the extension). I fixed it by amending your commit. Things should be fine from all point of view now.

Uh yes that makes much more sense. Thanks for taking care of it.

quarkus-bot · 2024-11-26T22:24:25Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 8164c7f.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 21	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	Native Tests - Security2	`Build`	Failures	Logs	Raw logs	🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/oidc-wiremock

📦 integration-tests/oidc-wiremock

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessAdminResourceWithFullCertChain line 256 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessAdminResourceWithKidOrChain line 415 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessResourceAzure line 84 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testCertChainWithCustomValidator line 207 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testFullCertChainWithOnlyRootInTruststore line 318 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.CodeFlowAuthorizationTest.testCodeFlowUserInfoCachedInIdToken line 433 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/oidc-wiremock

📦 integration-tests/oidc-wiremock

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessAdminResourceWithFullCertChain line 256 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessAdminResourceWithKidOrChain line 415 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessResourceAzure line 84 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testCertChainWithCustomValidator line 207 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testFullCertChainWithOnlyRootInTruststore line 318 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

✖ io.quarkus.it.keycloak.CodeFlowAuthorizationTest.testCodeFlowUserInfoCachedInIdToken line 433 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/oidc-wiremock

📦 integration-tests/oidc-wiremock

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessAdminResourceWithFullCertChain line 256 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessAdminResourceWithKidOrChain line 415 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testAccessResourceAzure line 84 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testCertChainWithCustomValidator line 207 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationTest.testFullCertChainWithOnlyRootInTruststore line 318 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

✖ io.quarkus.it.keycloak.CodeFlowAuthorizationTest.testCodeFlowUserInfoCachedInIdToken line 433 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

⚙️ Native Tests - Security2 #

- Failing: integration-tests/oidc-wiremock

📦 integration-tests/oidc-wiremock

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testAccessAdminResourceWithFullCertChain - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testAccessAdminResourceWithKidOrChain - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testAccessResourceAzure - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testCertChainWithCustomValidator - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testFullCertChainWithOnlyRootInTruststore - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)

✖ io.quarkus.it.keycloak.CodeFlowAuthorizationInGraalITCase.testCodeFlowUserInfoCachedInIdToken - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)

zakkak requested a review from xstefank November 22, 2024 15:36

quarkus-bot bot added area/health area/smallrye labels Nov 22, 2024

This comment has been minimized.

Sign in to view

gsmet requested changes Nov 22, 2024

View reviewed changes

zakkak force-pushed the 2024-11-21-jakarta-json-provider-registration branch from 57095af to c7a9032 Compare November 25, 2024 15:52

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Nov 25, 2024

zakkak requested a review from gsmet November 25, 2024 21:09

xstefank approved these changes Nov 26, 2024

View reviewed changes

gsmet requested changes Nov 26, 2024

View reviewed changes

zakkak force-pushed the 2024-11-21-jakarta-json-provider-registration branch from c7a9032 to 4aaf21d Compare November 26, 2024 15:28

zakkak changed the title ~~Register provider accessed by SmallRyeHealthReporter~~ Register jakarta.json.spi.JsonProvider service provider Nov 26, 2024

zakkak requested a review from gsmet November 26, 2024 15:30

gsmet approved these changes Nov 26, 2024

View reviewed changes

gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport labels Nov 26, 2024

gastaldi reviewed Nov 26, 2024

View reviewed changes

extensions/jsonp/deployment/src/main/java/io/quarkus/jsonp/deployment/JsonpProcessor.java Outdated Show resolved Hide resolved

gsmet force-pushed the 2024-11-21-jakarta-json-provider-registration branch from 4aaf21d to 2844378 Compare November 26, 2024 18:31

Register jakarta.json.spi.JsonProvider service provider

8164c7f

Register jakarta.json.spi.JsonProvider as a service provider so that both the service file and the implementations are included. Co-authored-by: Guillaume Smet <[email protected]>

gsmet force-pushed the 2024-11-21-jakarta-json-provider-registration branch from 2844378 to 8164c7f Compare November 26, 2024 18:39

zakkak merged commit 724b997 into quarkusio:main Nov 27, 2024
45 of 49 checks passed

zakkak deleted the 2024-11-21-jakarta-json-provider-registration branch November 27, 2024 07:57

quarkus-bot bot added this to the 3.18 - main milestone Nov 27, 2024

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 27, 2024

gsmet modified the milestones: 3.18 - main, 3.17.1 Nov 27, 2024

gsmet removed the triage/backport label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Register `jakarta.json.spi.JsonProvider` service provider #44649

Register `jakarta.json.spi.JsonProvider` service provider #44649

zakkak commented Nov 22, 2024

This comment has been minimized.

gsmet left a comment

gsmet commented Nov 22, 2024

zakkak commented Nov 25, 2024

gsmet commented Nov 25, 2024

zakkak commented Nov 25, 2024

gsmet commented Nov 25, 2024

zakkak commented Nov 25, 2024

gsmet commented Nov 25, 2024

zakkak commented Nov 25, 2024 •

edited

Loading

This comment has been minimized.

gsmet left a comment

gsmet Nov 26, 2024

zakkak Nov 26, 2024

gsmet commented Nov 26, 2024

zakkak commented Nov 26, 2024

quarkus-bot bot commented Nov 26, 2024 •

edited by github-actions bot

Loading

Register jakarta.json.spi.JsonProvider service provider #44649

Register jakarta.json.spi.JsonProvider service provider #44649

Conversation

zakkak commented Nov 22, 2024

This comment has been minimized.

gsmet left a comment

Choose a reason for hiding this comment

gsmet commented Nov 22, 2024

zakkak commented Nov 25, 2024

gsmet commented Nov 25, 2024

zakkak commented Nov 25, 2024

gsmet commented Nov 25, 2024

zakkak commented Nov 25, 2024

gsmet commented Nov 25, 2024

zakkak commented Nov 25, 2024 • edited Loading

This comment has been minimized.

gsmet left a comment

Choose a reason for hiding this comment

gsmet Nov 26, 2024

Choose a reason for hiding this comment

zakkak Nov 26, 2024

Choose a reason for hiding this comment

gsmet commented Nov 26, 2024

zakkak commented Nov 26, 2024

quarkus-bot bot commented Nov 26, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ JVM Tests - JDK 17 #

📦 integration-tests/oidc-wiremock

⚙️ JVM Tests - JDK 21 #

📦 integration-tests/oidc-wiremock

⚙️ JVM Tests - JDK 17 Windows #

📦 integration-tests/oidc-wiremock

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc-wiremock

Register `jakarta.json.spi.JsonProvider` service provider #44649

Register `jakarta.json.spi.JsonProvider` service provider #44649

zakkak commented Nov 25, 2024 •

edited

Loading

quarkus-bot bot commented Nov 26, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`