Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring up to date #212

Closed
faddat opened this issue Feb 9, 2023 · 3 comments
Closed

Bring up to date #212

faddat opened this issue Feb 9, 2023 · 3 comments

Comments

@faddat
Copy link

faddat commented Feb 9, 2023

Every version of the SDK in the 46 series from 0 to 6 has been retracted.

46.0-4: bank module bug
46.4-6 groups issues

We also need to use tendermint 34.26 because It contains a critical peer-to-peer patch.

Main branch needs:

SDK 46.9
Tendermint 34.26
Wasmd v0.30.0 (notional 46 fork)
IBC v6
async-icq v6
packet-forward-middleware v6
token factory

Once we have gotten these landed, we should find that we are in a far better place for development. I also suspect that these will resolve the IAVL issue, I believe that most likely the IAVL issue is coming from using various mismatched or old dependencies. A good example of this is the version of IBC that we were using due to the ICQ shim. It wasn't even full v5, it was a release candidate version.

The second good example is WASMD. Our integration work for SDK46 and WASMD did not actually complete until the release of WASMD 29, however this repository is referencing WASMD27.

@faddat
Copy link
Author

faddat commented Feb 10, 2023

Related work:

Notes:

this commit 3d4d7ac of the packet-seq-return branch of quasar/wasmd fails every test.

Was the most recent commit.

github.com/CosmWasm/wasmd/x/wasm/keeper

x/wasm/keeper/handler_plugin.go:198:42: unknown field Sequence in struct literal of type "github.com/cosmos/ibc-go/v5/modules/apps/transfer/types".MsgTransferResponse
? github.com/CosmWasm/wasmd/app/params [no test files]
? github.com/CosmWasm/wasmd/cmd/contract_tests [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/blockchain [no test files]
FAIL github.com/CosmWasm/wasmd/app [build failed]
FAIL github.com/CosmWasm/wasmd/benchmarks [build failed]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/consensus [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/libs/bits [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/crypto [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/mempool [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/p2p [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/privval [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/state [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/statesync [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/store [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/types [no test files]
? github.com/CosmWasm/wasmd/third_party/proto/tendermint/version [no test files]
FAIL github.com/CosmWasm/wasmd/x/wasm [build failed]
FAIL github.com/CosmWasm/wasmd/x/wasm/client/cli [build failed]
? github.com/CosmWasm/wasmd/x/wasm/keeper/wasmtesting [no test files]
ok github.com/CosmWasm/wasmd/x/wasm/ioutils (cached)
FAIL github.com/CosmWasm/wasmd/x/wasm/keeper [build failed]
ok github.com/CosmWasm/wasmd/x/wasm/types (cached)
FAIL
make: *** [test-unit] Error 1

@faddat
Copy link
Author

faddat commented Feb 10, 2023

ibc-go in quasar and ibc-go in wasmd are differentially versioned because of quasar's support for icq. Trying to prepare an updated branch.

@faddat
Copy link
Author

faddat commented Feb 10, 2023

Updated icq succeeded, and is a tagged release of:

github.com/notional-labs/ibc-go v5.2.0-icq

@lubkoll lubkoll closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants