Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quasar Plugin installs node-sass, even if dart-sass is already installed #28

Open
eagerestwolf opened this issue Dec 23, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@eagerestwolf
Copy link

Describe the bug
When setting up a Vue application using the Vue CLI, users are given the option to install either node-sass or dart-sass. When installing Quasar with the Vue CLI and selecting Sass or SCSS as the CSS processor, Quasar installs node-sass, even if dart-sass is installed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Vue application using the Vue CLI (vue create [appname])
  2. Manually select features
  3. Select CSS Pre-processors option
  4. Select Sass/SCSS (with dart-sass)
  5. Finish setting up app with Vue CLI
  6. Change to app folder (cd [appname])
  7. Install Quasar (vue add quasar)
  8. During Quasar setup, select either Sass with indented syntax or Sass with SCSS syntax

Expected behavior
Quasar should not install a Sass pre-processor at all. It's the responsibility of Vue to compile the Sass, not Quasar. However, if you want to ensure the user has a Sass pre-processor installed, you should check for either node-sass or dart-sass.

Platform:
OS: Windows 10 (Build 18363.535)
Node: 12.13.1
NPM: 6.13.1
Yarn: 1.21.1
Browsers: Microsoft Edge (Version 44.18362.449.0), Google Chrome (Version 79.0.3945.88)

Additional context
It should also be noted that if you are going to default to node-sass or dart-sass, you should default to dart-sass anyway because that's the preferred implementation by the Sass development team (reference), and it's significantly faster than node-sass anyway.

@eagerestwolf eagerestwolf added the bug Something isn't working label Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant