ncm-nfs: Allow daemon to reload to be specified #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpoely86
previously approved these changes
Aug 18, 2023
wpoely86
reviewed
Aug 18, 2023
|
Just realising I'll probably have to fix the tests now I've changed the default. |
The name of the service/daemon is OS dependent, default to the more modern name. For example in EL6 it was `nfs`, in EL7 `nfs` was a symlink to `nfs-server`, in EL8 only `nfs-server` exists and in Ubuntu it is `nfs-kernel-server`.
|
Okay all done, @wpoely86 can you re-review? |
wpoely86
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the service/daemon is OS dependent, default to the more modern name.
For example in EL6 it was
nfs, in EL7nfswas a symlink tonfs-server, in EL8 onlynfs-serverexists and in Ubuntu it isnfs-kernel-server.Resolves #1618.