ncm-network: add additional bonding options #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned21
reviewed
Nov 19, 2024
ncm-network/src/main/pan/components/network/types/network/interface.pan
Outdated
Show resolved
Hide resolved
ncm-network/src/main/pan/components/network/types/network/interface.pan
Outdated
Show resolved
Hide resolved
aka7
force-pushed
the
ncm_network_bonding_opts
branch
from
f23ccd3 to
a67cf52
Compare
jrha
reviewed
Nov 19, 2024
ncm-network/src/main/pan/components/network/types/network/interface.pan
Outdated
Show resolved
Hide resolved
ncm-network/src/main/pan/components/network/types/network/interface.pan
Outdated
Show resolved
Hide resolved
ncm-network/src/main/pan/components/network/types/network/interface.pan
Outdated
Show resolved
Hide resolved
ncm-network/src/main/pan/components/network/types/network/interface.pan
Outdated
Show resolved
Hide resolved
|
@aka7 we just merge an update to the CI tests. It should not change the result but probably it a good idea to rebase to ensure everything is ok. |
add additional bonding options
aka7
force-pushed
the
ncm_network_bonding_opts
branch
3 times, most recently
from
9215131 to
a0c7fd5
Compare
aka7
force-pushed
the
ncm_network_bonding_opts
branch
from
a0c7fd5 to
bda7418
Compare
jrha
approved these changes
Nov 20, 2024
|
Wait, are any of these newly added fields supported by the initscripts backend? |
we use few already. We are already setting the following with ifcfg, which I know works. I haven't yet checked for others added. BONDING_OPTS='arp_interval=8000 arp_ip_target=10.x.x.x arp_validate=all mode=active-backup primary=eth0 primary_reselect=always resend_igmp=2' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add additional bonding options, as per https://docs.rs/nmstate/latest/nmstate/struct.BondOptions.html#fields
Why the change is necessary: ability to set bonding options such as
resend_igcmp and others,
What backwards incompatibility it may introduce: none, all options added are optional.