Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixing '..' in symlinks with Windows junctions #1200

Open
strager opened this issue Feb 12, 2024 · 0 comments
Open

Fix mixing '..' in symlinks with Windows junctions #1200

strager opened this issue Feb 12, 2024 · 0 comments
Labels
false positive Severe bug: quick-lint-js rejects valid code

Comments

@strager
Copy link
Collaborator

strager commented Feb 12, 2024

See Test_File_Canonical.symlink_with_dot_dot_escapes_junction
@strager strager added the false positive Severe bug: quick-lint-js rejects valid code label Feb 12, 2024
strager added a commit that referenced this issue Feb 12, 2024
@strager
feat(io): support Windows junctions
137cde4 
We support symlinks on Windows but not junctions (which are similar).
Teach canonicalize_path to follow junctions, handling them similarly to
symlinks. (The implementation is wrong, but wrong in some edge cases
(#1200) is perhaps a
bit better than consistently crashing (QLJS_UNIMPLEMENTED).)
strager added a commit that referenced this issue Feb 17, 2024
@strager
feat(io): support Windows junctions
748b775 
We support symlinks on Windows but not junctions (which are similar).
Teach canonicalize_path to follow junctions, handling them similarly to
symlinks. (The implementation is wrong, but wrong in some edge cases
(#1200) is perhaps a
bit better than consistently crashing (QLJS_UNIMPLEMENTED).)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false positive Severe bug: quick-lint-js rejects valid code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strager