Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs Flymake: diagnostics not cleared sometimes #398

Open
Tracked by #409
strager opened this issue Jul 22, 2021 · 3 comments · May be fixed by #409
Open
Tracked by #409

Emacs Flymake: diagnostics not cleared sometimes #398

strager opened this issue Jul 22, 2021 · 3 comments · May be fixed by #409

Comments

@strager
Copy link
Collaborator

strager commented Jul 22, 2021

Repro:

  1. C-x b RET (open *scratch*)
  2. M-x js-mode RET
  3. Go to the first line and insert //
  4. Go to the second line and insert //

At this point, Flymake should report no issues, but it reports an unclosed regexp literal error.

  1. On a new line, type documents
  2. Hover the mouse cursor over the word 'documents' and observe:
    Screenshot from 2021-07-21 20-18-08
@wgrr
Copy link
Contributor

wgrr commented Jul 22, 2021 •
edited
Loading

@strager i think this bug is related with state track of quick-lint-js process, reported a new issue (#400) for the crash that this input is doing to quick-lint-js

@strager
Copy link
Collaborator Author

strager commented Jul 22, 2021

@strager i think this bug is related with state track of quick-lint-js process, reported a new issue (#400) for the crash that this input is doing to quick-lint-js

Do you think the plugin gets confused when quick-lint-js crashes?

@wgrr
Copy link
Contributor

wgrr commented Jul 22, 2021 •
edited
Loading

Do you think the plugin gets confused when quick-lint-js crashes?

Yes, I'm still investigating that, apparently if quick-lint-js crashes (make-process) is never calling us back so we don't have a chance to disable ourselves or update the current errors, but im not 100% sure about this, what im tho is we are never taking the :panic branch, even if we crash.
I'll bet it has somewhat related with signals.

wgrr added a commit to wgrr/quick-lint-js that referenced this issue Jul 24, 2021
@wgrr
plugin/emacs: Don't use region intersection in Flymake while reporting
6a223f8 
This is causing diagnostics to not be cleared sometimes (see quick-lint#398), it
was first introduced for developement, because restarting Flymake
without changes in buffers would not delete old diagnostics, I think
it's fine if we not specify this option.

However I suspect this is a bug in Flymake.

Signed-off-by: wagner riffel <[email protected]>
@wgrr wgrr mentioned this issue Jul 24, 2021
Closed
wgrr added a commit to wgrr/quick-lint-js that referenced this issue Jul 31, 2021
@wgrr
plugin/emacs: Don't use region intersection in Flymake while reporting
e5299e9 
This is causing diagnostics to not be cleared sometimes (see quick-lint#398), it
was first introduced for developement, because restarting Flymake
without changes in buffers would not delete old diagnostics, I think
it's fine if we not specify this option.

However I suspect this is a bug in Flymake.

Signed-off-by: wagner riffel <[email protected]>
(cherry picked from commit 6a223f8)
wgrr added a commit to wgrr/quick-lint-js that referenced this issue Aug 1, 2021
@wgrr
plugin/emacs: Don't use region intersection in Flymake while reporting
c707b8b 
This is causing diagnostics to not be cleared sometimes (see quick-lint#398), it
was first introduced for developement, because restarting Flymake
without changes in buffers would not delete old diagnostics, I think
it's fine if we not specify this option.

However I suspect this is a bug in Flymake.

Signed-off-by: wagner riffel <[email protected]>
(cherry picked from commit 6a223f8)
wgrr added a commit to wgrr/quick-lint-js that referenced this issue Aug 1, 2021
@wgrr
plugin/emacs: Don't use region intersection in Flymake while reporting
c491432 
This is causing diagnostics to not be cleared sometimes (see quick-lint#398), it
was first introduced for developement, because restarting Flymake
without changes in buffers would not delete old diagnostics, I think
it's fine if we not specify this option.

However I suspect this is a bug in Flymake.

Signed-off-by: wagner riffel <[email protected]>
(cherry picked from commit 6a223f8)
wgrr added a commit to wgrr/quick-lint-js that referenced this issue Aug 1, 2021
@wgrr
plugin/emacs: Don't use region intersection in Flymake while reporting
12a2216 
This is causing diagnostics to not be cleared sometimes (see quick-lint#398), it
was first introduced for developement, because restarting Flymake
without changes in buffers would not delete old diagnostics, I think
it's fine if we not specify this option.

However I suspect this is a bug in Flymake.

Signed-off-by: wagner riffel <[email protected]>
(cherry picked from commit 6a223f8)
@wgrr wgrr linked a pull request Aug 1, 2021 that will close this issue
Draft
3 tasks
wgrr added a commit to wgrr/quick-lint-js that referenced this issue Aug 11, 2021
@wgrr
plugin/emacs: Don't use region intersection in Flymake while reporting
387222b 
This is causing diagnostics to not be cleared sometimes (see quick-lint#398), it
was first introduced for developement, because restarting Flymake
without changes in buffers would not delete old diagnostics, I think
it's fine if we not specify this option.

However I suspect this is a bug in Flymake.

Signed-off-by: wagner riffel <[email protected]>
(cherry picked from commit 6a223f8)
@strager strager linked a pull request Sep 16, 2021 that will close this issue
wip: fix #396, #395 and #398 #409
Draft
3 tasks
@strager strager mentioned this issue Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wip: fix #396, #395 and #398 wgrr/quick-lint-js
2 participants
@strager @wgrr