Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private APIs #3001

Closed
n8henrie opened this issue Feb 6, 2024 · 0 comments · Fixed by #3002
Closed

Remove private APIs #3001

n8henrie opened this issue Feb 6, 2024 · 0 comments · Fixed by #3002

Comments

@n8henrie
Copy link
Member

n8henrie commented Feb 6, 2024

Quicksilver currently relies on private APIs, primarily for its animations.

These are extremely difficult to debug and maintain as they are undocumented. For example: #2962

As mentioned in that thread, one approach would be to rip out the private APIs and everything that depends on them.

I expect the immediate effects would be a far less pretty Quicksilver, as these seem to be primarily used for animations. However, it should help avoid fiascos like the current (long) list of Sonoma issues.

n8henrie added a commit that referenced this issue Feb 6, 2024
This removes `CGSPrivate.h`, `CPSPrivate.h`, as well as
`QSCGSTransition.{h,m}` which only seemed to serve as adapters for them.
It additionally either removes entirely or comments out (to serve as a
quick and dirty reference for reimplementation) code that depended on
these files.

This will break the pretty animations.

See also: #3001
@n8henrie n8henrie linked a pull request Feb 6, 2024 that will close this issue
n8henrie added a commit that referenced this issue Mar 30, 2024
* Remove the private APIs entirely

This removes `CGSPrivate.h`, `CPSPrivate.h`, as well as
`QSCGSTransition.{h,m}` which only seemed to serve as adapters for them.
It additionally either removes entirely or comments out (to serve as a
quick and dirty reference for reimplementation) code that depended on
these files.

This will break the pretty animations.

See also: #3001

* Revert "#FIXME: Force-disable superfluous effects on startup"

This reverts commit a5640c6.

* Cleanup unused

* Remove references to flare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant