Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] part types #379

Open
nicolas-sitylb opened this issue Oct 3, 2023 · 1 comment
Open

[ENH] part types #379

nicolas-sitylb opened this issue Oct 3, 2023 · 1 comment

Comments

@nicolas-sitylb
Copy link
Contributor

Hello QWAT team,

some official survey offices use more part types than those provided in the official QWAT data model, for example (here in french) :
image

whereas the actual QWAT data model only provides those values:

SELECT id, value_fr, value_en, value_ro FROM qwat_vl.part_type;

image

Therefore, the correspondence is complicated. This is especially true as there are no "unknown"-like values.

That's why I'm asking if it could be possible to integrate, at least the most common values in the official QWAT data model?

(It would also be convenient to use the default values 101, 102 and 103 (see: #378 ))

Thanks.

@ponceta
Copy link
Member

ponceta commented Oct 5, 2023

Very good input, it would be nice to list elements not in this list and check whether they are not in some other class in QWAT.

I've added a delta to your PR.

@nicolas-sitylb nicolas-sitylb changed the title ENH: part types [ENH] part types Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants