From ff4c80047ec5c5ee4b6913ab0f7826003fefd1bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Thu, 21 Dec 2023 10:19:25 +0100 Subject: [PATCH 1/5] Bump version to 1.7.99.9000 --- DESCRIPTION | 2 +- NEWS.md | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 57c3a0547..0fe199d39 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: DBItest Title: Testing DBI Backends -Version: 1.7.3.9016 +Version: 1.7.99.9000 Date: 2023-12-21 Authors@R: c( person("Kirill", "Müller", , "kirill@cynkra.com", role = c("aut", "cre"), diff --git a/NEWS.md b/NEWS.md index 32582d751..80806ec4a 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,12 @@ +# DBItest 1.7.99.9000 (2023-12-21) + +## Chore + +- DBI is on CRAN. + + # DBItest 1.7.3.9016 (2023-12-21) ## Chore From dd1d08286a108dbf4341bf9bdd207ffe30ac4bca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Thu, 21 Dec 2023 10:20:03 +0100 Subject: [PATCH 2/5] Bump version to 1.8.0 --- DESCRIPTION | 2 +- NEWS.md | 215 ++++++++-------------------------------------------- 2 files changed, 32 insertions(+), 185 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 0fe199d39..5a054f268 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: DBItest Title: Testing DBI Backends -Version: 1.7.99.9000 +Version: 1.8.0 Date: 2023-12-21 Authors@R: c( person("Kirill", "Müller", , "kirill@cynkra.com", role = c("aut", "cre"), diff --git a/NEWS.md b/NEWS.md index 80806ec4a..09d3bca0d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,235 +1,82 @@ -# DBItest 1.7.99.9000 (2023-12-21) - -## Chore - -- DBI is on CRAN. - - -# DBItest 1.7.3.9016 (2023-12-21) - -## Chore - -- Bump DBI dependency. - -- Revdepcheck results. +# DBItest 1.8.0 (2023-12-21) +## Bug fixes -# DBItest 1.7.3.9015 (2023-12-20) +- Fix two binding tests (#321). +- Typo. +- Skip test if dplyr is not installed. +- Fix `create_roundtrip_keywords` and `create_roundtrip_quotes` tests (#283). ## Features - Relax specification of `dbUnquoteIdentifier()`, character vectors are now allowed too. - -## Chore - -- Install DBI from CRAN. - - -# DBItest 1.7.3.9014 (2023-12-18) - -## Features - - Specify `dbFetchChunk()` (#331). - - Inline all tests for `dbBind()` (#326). +- Require support for `dbFetch(n = NA)` (#296, #316). +- New `allow_na_rows_affected` tweak to support `NA` values returned from `dbGetRowsAffected()` (#297, #312). +- Add adbi to check matrix (#314). +- Switch to nanoarrow (#291). +- Basic tests for the new `db*Arrow()` interface (#287). +- New `skip_if_not_dbitest()` (#289). +- Reenable ODBC MySQL tests (#288). +- Tweak read_table_missing test (#285). +- `reexport` test uses interface for dev DBI if the backend is compatible with DBItest \> 1.7.3. +This reverts commit bbb444486d0b663a89e66dd61c8b5a97c8e18651. ## Chore +- DBI is on CRAN. +- Bump DBI dependency. +- Revdepcheck results. +- Install DBI from CRAN. - Remove rlang qualification (#332). - - Remove double `as.data.frame()` (#330). - - Test for `dbBindArrow()` (#328). - - Work around constructive problem (#327). - - Inlining (#325). - - Inlining (#324). - - Towards inlining bind tests (#323). - - -# DBItest 1.7.3.9013 (2023-12-17) - -## Bug fixes - -- Fix two binding tests (#321). - -## Features - -- Require support for `dbFetch(n = NA)` (#296, #316). - -- New `allow_na_rows_affected` tweak to support `NA` values returned from `dbGetRowsAffected()` (#297, #312). - -- Add adbi to check matrix (#314). - -## Chore - - Towards generating expressions for bind checks (#320). - - Avoid R6 for testing `dbBind()` (#319). - - Consistent use of `skip_if_not_dbitest()` (#317). - - Disable Arrow skips (#303). - - Slightly better code generated for `tweaks()` (#313). - -## Testing - -- Run DBItest for SQLite as part of the checks here (#318). - -- Enable remaining Arrow tests (#307). - -## Uncategorized - -- Merge pull request #315 from r-dbi/b-odbc. - - Fix compatibility with odbc - - -# DBItest 1.7.3.9012 (2023-11-22) - -## Chore - - No longer need `as.data.frame()` twice for Arrow (#302). - - Breadcrumbs (#305). - - Align paths to duckdb in `Makefile` (#306). - - Modernize `sql_union()` (#304). - - Add new `dbFetchArrowChunk()` generic (#301). - - -# DBItest 1.7.3.9011 (2023-11-09) - -## Chore - - Add Aviator configuration. - -## Documentation - -- Avoid error if RSQLite is not installed. - -## Testing - -- Fix checks without suggested packages (#300). - - -# DBItest 1.7.3.9010 (2023-10-30) - -## Bug fixes - -- Typo. - -## Chore - - Adapt to changed duckdb directory. - - -# DBItest 1.7.3.9009 (2023-10-09) - -## Bug fixes - -- Skip test if dplyr is not installed. - - -# DBItest 1.7.3.9008 (2023-09-25) - -## Chore - - Simplify workflow. - - -# DBItest 1.7.3.9007 (2023-09-01) - -## Features - -- Switch to nanoarrow (#291). - -## Chore - - Fix CI/CD (#295). - - -# DBItest 1.7.3.9006 (2023-08-30) - -## Chore - - Try fixing odbc workflows. - - Bump dependencies in GitHub actions. +- Refactor: Prefer functions over constants (#270). +- Make better use of `trivial_df()` (#284). +## Documentation -# DBItest 1.7.3.9005 (2023-03-24) - -- Internal changes only. - - -# DBItest 1.7.3.9004 (2023-03-21) - -- Internal changes only. - - -# DBItest 1.7.3.9003 (2022-12-30) - -- Internal changes only. - - -# DBItest 1.7.3.9002 (2022-12-26) - -## Features - -- Basic tests for the new `db*Arrow()` interface (#287). - - -# DBItest 1.7.3.9001 (2022-12-24) - -## Bug fixes - -- Fix `create_roundtrip_keywords` and `create_roundtrip_quotes` tests (#283). - -## Features - -- New `skip_if_not_dbitest()` (#289). - -- Reenable ODBC MySQL tests (#288). - -- Tweak read_table_missing test (#285). - -- `reexport` test uses interface for dev DBI if the backend is compatible with DBItest > 1.7.3. - -This reverts commit bbb444486d0b663a89e66dd61c8b5a97c8e18651. - -## Chore +- Avoid error if RSQLite is not installed. -- Refactor: Prefer functions over constants (#270). +## Testing -- Make better use of `trivial_df()` (#284). +- Run DBItest for SQLite as part of the checks here (#318). +- Enable remaining Arrow tests (#307). +- Fix checks without suggested packages (#300). ## Uncategorized +- Merge pull request #315 from r-dbi/b-odbc. + Fix compatibility with odbc +- Internal changes only. - Merge pull request #280 from r-dbi/f-ref-3. - - - - Merge remote-tracking branch 'refs/remotes/origin/main'. - - - Merged cran-1.7.3 into main. - -# DBItest 1.7.3.9000 (2022-10-18) - -- Internal changes only. - - # DBItest 1.7.3 (2022-10-18) ## Features From 91396d2c1b9ce2558b73eb4b83ceb8300c02a468 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Thu, 21 Dec 2023 10:20:05 +0100 Subject: [PATCH 3/5] CRAN comments --- cran-comments.md | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 93fcdfe72..7bcd17e0a 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,6 +1,15 @@ -DBItest 1.7.3 +DBItest 1.8.0 + +## R CMD check results + +- [x] Checked locally, R 4.3.2 +- [x] Checked on CI system, R 4.3.2 +- [x] Checked on win-builder, R devel ## Current CRAN check results -- [x] Checked on 2022-10-18, problems found: https://cran.r-project.org/web/checks/check_results_DBItest.html -- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64, r-patched-linux-x86_64, r-release-linux-x86_64, r-release-macos-arm64, r-release-macos-x86_64, r-release-windows-x86_64, r-oldrel-macos-arm64, r-oldrel-macos-x86_64, r-oldrel-windows-ix86+x86_64: available in Additional_dependencies +- [x] Checked on 2023-12-21, problems found: https://cran.r-project.org/web/checks/check_results_DBItest.html +- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64, r-patched-linux-x86_64, r-release-linux-x86_64, r-release-macos-arm64, r-release-macos-x86_64, r-release-windows-x86_64, r-oldrel-macos-arm64, r-oldrel-windows-x86_64 + Package suggested but not available for checking: ‘dblog’ + +Check results at: https://cran.r-project.org/web/checks/check_results_DBItest.html From 90f688011fd3cb7f7c9f60c4baf424d45161d8a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Thu, 21 Dec 2023 12:57:17 +0100 Subject: [PATCH 4/5] Fix link --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b3b0e814f..75f9fcaeb 100644 --- a/README.md +++ b/README.md @@ -59,5 +59,5 @@ Further reading: --- Please note that the 'DBItest' project is released with a -[Contributor Code of Conduct](https://dbitest.r-dbi.org/code_of_conduct). +[Contributor Code of Conduct](https://dbitest.r-dbi.org/CODE_OF_CONDUCT.html). By contributing to this project, you agree to abide by its terms. From 3ce6978589cc74ea24be93fdf04ab2c6cb35e812 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Thu, 21 Dec 2023 13:13:18 +0100 Subject: [PATCH 5/5] NEWS and CRAN comments [ci skip] --- NEWS.md | 68 +++++++++++++++++++----------------------------- cran-comments.md | 4 +-- 2 files changed, 28 insertions(+), 44 deletions(-) diff --git a/NEWS.md b/NEWS.md index 09d3bca0d..f91f174b7 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,57 +4,50 @@ ## Bug fixes -- Fix two binding tests (#321). -- Typo. -- Skip test if dplyr is not installed. - Fix `create_roundtrip_keywords` and `create_roundtrip_quotes` tests (#283). ## Features - Relax specification of `dbUnquoteIdentifier()`, character vectors are now allowed too. -- Specify `dbFetchChunk()` (#331). + +- Specify `dbFetchChunk()` (#331), `dbFetchArrowChunk()` (#301) and `dbBindArrow()` (#328). + - Inline all tests for `dbBind()` (#326). + - Require support for `dbFetch(n = NA)` (#296, #316). + - New `allow_na_rows_affected` tweak to support `NA` values returned from `dbGetRowsAffected()` (#297, #312). -- Add adbi to check matrix (#314). + - Switch to nanoarrow (#291). + - Basic tests for the new `db*Arrow()` interface (#287). + - New `skip_if_not_dbitest()` (#289). -- Reenable ODBC MySQL tests (#288). -- Tweak read_table_missing test (#285). + - `reexport` test uses interface for dev DBI if the backend is compatible with DBItest \> 1.7.3. -This reverts commit bbb444486d0b663a89e66dd61c8b5a97c8e18651. + +- Slightly better code generated for `tweaks()` (#313). + +## CI/CD + +- Add adbi to check matrix (#314). + +- Reenable ODBC MySQL tests (#288). + +- Tweak `read_table_missing` test (#285). ## Chore -- DBI is on CRAN. -- Bump DBI dependency. -- Revdepcheck results. -- Install DBI from CRAN. - Remove rlang qualification (#332). -- Remove double `as.data.frame()` (#330). -- Test for `dbBindArrow()` (#328). -- Work around constructive problem (#327). -- Inlining (#325). -- Inlining (#324). -- Towards inlining bind tests (#323). -- Towards generating expressions for bind checks (#320). -- Avoid R6 for testing `dbBind()` (#319). + +- No longer need `as.data.frame()` twice for Arrow (#302, #330). + - Consistent use of `skip_if_not_dbitest()` (#317). + - Disable Arrow skips (#303). -- Slightly better code generated for `tweaks()` (#313). -- No longer need `as.data.frame()` twice for Arrow (#302). -- Breadcrumbs (#305). -- Align paths to duckdb in `Makefile` (#306). + - Modernize `sql_union()` (#304). -- Add new `dbFetchArrowChunk()` generic (#301). -- Add Aviator configuration. -- Adapt to changed duckdb directory. -- Simplify workflow. -- Fix CI/CD (#295). -- Try fixing odbc workflows. -- Bump dependencies in GitHub actions. -- Refactor: Prefer functions over constants (#270). + - Make better use of `trivial_df()` (#284). ## Documentation @@ -64,17 +57,10 @@ This reverts commit bbb444486d0b663a89e66dd61c8b5a97c8e18651. ## Testing - Run DBItest for SQLite as part of the checks here (#318). -- Enable remaining Arrow tests (#307). -- Fix checks without suggested packages (#300). -## Uncategorized +- Enable remaining Arrow tests (#307). -- Merge pull request #315 from r-dbi/b-odbc. - Fix compatibility with odbc -- Internal changes only. -- Merge pull request #280 from r-dbi/f-ref-3. -- Merge remote-tracking branch 'refs/remotes/origin/main'. -- Merged cran-1.7.3 into main. +- Fix checks without suggested packages (#300). # DBItest 1.7.3 (2022-10-18) diff --git a/cran-comments.md b/cran-comments.md index 7bcd17e0a..747ff333e 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -9,7 +9,5 @@ DBItest 1.8.0 ## Current CRAN check results - [x] Checked on 2023-12-21, problems found: https://cran.r-project.org/web/checks/check_results_DBItest.html -- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64, r-patched-linux-x86_64, r-release-linux-x86_64, r-release-macos-arm64, r-release-macos-x86_64, r-release-windows-x86_64, r-oldrel-macos-arm64, r-oldrel-windows-x86_64 +- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64, r-patched-linux-x86_64, r-release-linux-x86_64, r-release-macos-arm64, r-release-macos-x86_64, r-release-windows-x86_64, r-oldrel-macos-arm64, r-oldrel-windows-x86_64: Additional_repositories Package suggested but not available for checking: ‘dblog’ - -Check results at: https://cran.r-project.org/web/checks/check_results_DBItest.html