Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reword warning message for misuse of dbGetQuery()/dbSendQuery()/dbFetch() #524

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

mikmart
Copy link
Contributor

@mikmart mikmart commented Oct 16, 2024

Fixes #523.

@@ -44,6 +44,7 @@ Suggests:
callr,
cli,
DBItest (>= 1.8.0),
decor,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for running tests but wasn't picked up as a dev dependency when running pak::pak() after cloning.

@krlmlr krlmlr added this pull request to the merge queue Nov 17, 2024
@krlmlr krlmlr removed this pull request from the merge queue due to a manual request Nov 17, 2024
@krlmlr krlmlr added this pull request to the merge queue Nov 17, 2024
@krlmlr
Copy link
Member

krlmlr commented Nov 17, 2024

Thanks!

@krlmlr krlmlr changed the title Reword warning message for misuse of dbGetQuery()/dbSendQuery()/dbFetch() docs: Reword warning message for misuse of dbGetQuery()/dbSendQuery()/dbFetch() Nov 17, 2024
@krlmlr krlmlr removed this pull request from the merge queue due to a manual request Nov 17, 2024
@krlmlr krlmlr added this pull request to the merge queue Nov 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2024
@krlmlr krlmlr added this pull request to the merge queue Nov 17, 2024
Merged via the queue into r-dbi:main with commit a12b12f Nov 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbFetch() gives confusing warning when used with dbSendStatement()
2 participants