Add comma as a splitting token in toTitleCase() #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools::toTitleCase()
documentation indicates that words surrounded by single quotes are protected from change:But this doesn't work when the quoted word is immediately followed by a comma:
Created on 2024-07-12 with reprex v2.1.1
The proposed patch fixes this by adding the comma to the splitting tokens.
I have verified on my local library on 1400 R packages that this does not cause any unexpected changes when applied to their
Title
field inDESCRIPTION
.This is the result of a collaboration with @sarahzeller @shannonpileggi @reikookamoto at the R Dev Day PLUS 2024.
Once checks have been confirmed passing, I will submit this report & patch proposal as a new bugzilla entry.