Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #112

wants to merge 1 commit into from

Conversation

Lextuga007
Copy link

@Lextuga007 Lextuga007 commented Mar 31, 2023 •
edited
Loading

Fixes #111

@Lextuga007
Update README.md
fcd60cf 
Removed brackets
@maelle
Copy link
Contributor

maelle commented Mar 31, 2023

Awesome! If you change your PR text to "Fix #111", when I merge it the PR will be automatically closed cf https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@Lextuga007 Lextuga007 closed this Mar 31, 2023
@Lextuga007 Lextuga007 deleted the 111-removed-brackets branch March 31, 2023 12:23
@Lextuga007
Copy link
Author

I've updated it on own repository but it's not updating in this pull request and looks like I've deleted it here! Do I do a new pull request?

@maelle
Copy link
Contributor

maelle commented Mar 31, 2023

oops sorry I meant in the first comment, adding "Fixes #111" on a line before "Removed brackets"

image

@Lextuga007 Lextuga007 restored the 111-removed-brackets branch March 31, 2023 13:15
@Lextuga007
Copy link
Author

My misunderstanding! I've edited the text 😄

@Lextuga007 Lextuga007 reopened this Mar 31, 2023
@Lextuga007
Copy link
Author

Yes! I didn't realise I could 😄

@maelle
Copy link
Contributor

maelle commented Mar 31, 2023

oooh but I now realize we're not having this convo in goodpress 😂 🤦‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

output: hugodown::md_document() in README shouldn't have brackets
2 participants
@Lextuga007 @maelle