Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return_linter() should allow switch() where every entry has an exit call #2343

Closed
MichaelChirico opened this issue Nov 23, 2023 · 0 comments · Fixed by #2422
Closed

return_linter() should allow switch() where every entry has an exit call #2343

MichaelChirico opened this issue Nov 23, 2023 · 0 comments · Fixed by #2422
Labels
false-positive code that shouldn't lint, but does
Milestone
3.2.0

Comments

@MichaelChirico
Copy link
Collaborator 

          @MichaelChirico I don't think we should give a lint here. In my opinion this is a false positive, as there is no way an implicit return is given.

My first implementation handled this accordingly. Maybe we could do that again.

Originally posted by @MEO265 in #2271 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive code that shouldn't lint, but does
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

handle terminal switch() in return_linter() r-lib/lintr
1 participant
@MichaelChirico