look for is.unsorted() behavior in sort_linter #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2076 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 117 117
Lines 5106 5117 +11
=======================================
+ Hits 5088 5099 +11
Misses 18 18
|
AshesITR
reviewed
Aug 11, 2023
AshesITR
previously approved these changes
Aug 11, 2023
|
Ah that's annoying.
So I can cleanly merge a simple NEWS update locally, but not on the web without dismissing the review. Alas. |
| @@ -23,6 +23,7 @@ | |||
| + `yoda_test_linter()` | |||
| * `sprintf_linter()` is pipe-aware, so that `x %>% sprintf(fmt = "%s")` no longer lints (#1943, @MichaelChirico). | |||
| * `line_length_linter()` helpfully includes the line length in the lint message (#2057, @MichaelChirico). | |||
| * `sort_linter()` checks for code like `x == sort(x)` which is better served by using the function `is.unsorted()` (part of #884, @MichaelChirico). | |||
There was a problem hiding this comment.
This is pretty cool! I had no idea that this function existed 🙈
AshesITR
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2072, part of #884