Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rep_len_linter #2286

Merged
merged 13 commits into from
Nov 19, 2023
Merged

New rep_len_linter #2286

merged 13 commits into from
Nov 19, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884

No hits on {lintr}

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0aefa5f) 99.40% compared to head (01b3d15) 99.40%.

❗ Current head 01b3d15 differs from pull request most recent head f1634ef. Consider uploading reports for the commit f1634ef to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2286   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         117      117           
  Lines        5334     5334           
=======================================
  Hits         5302     5302           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/rep_len_linter.R Outdated Show resolved Hide resolved
R/rep_len_linter.R Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

Vectorizatiion & metadata tests are missing. The rest looks fine.

),
rep_len_linter()
)
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing terminal newline

AshesITR
AshesITR previously approved these changes Nov 19, 2023
@AshesITR AshesITR merged commit e969d64 into main Nov 19, 2023
20 checks passed
@MichaelChirico MichaelChirico deleted the rep_len branch November 19, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants