New list_comparison_linter #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
=======================================
Coverage 99.44% 99.45%
=======================================
Files 115 116 +1
Lines 5258 5286 +28
=======================================
+ Hits 5229 5257 +28
Misses 29 29 ☔ View full report in Codecov by Sentry. |
|
Add |
MichaelChirico
commented
Nov 16, 2023
AshesITR
reviewed
Nov 18, 2023
|
|
||
|
|
||
| cases <- expand.grid( | ||
| list_mapper = c("lapply", "map", "Map"), |
AshesITR
reviewed
Nov 18, 2023
| linter <- list_comparison_linter() | ||
| lint_msg <- rex::rex("a list(), is being coerced for comparison") | ||
|
|
||
|
|
AshesITR
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #884
No hits on {lintr}