-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New nrow_subset_linter #2298
New nrow_subset_linter #2298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 119 119
Lines 5392 5392
=======================================
Hits 5359 5359
Misses 33 33 ☔ View full report in Codecov by Sentry. |
Will convert the TODO to new issues after initial review to satisfy |
Could use a lot more testing, especially negatives, vectorization and metadata. |
Part of #884
No hits on {lintr}
Will convert some of the TODOs as follow-up issues, I was surprised how many hits this simple version gets already though.