Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nrow_subset_linter #2298

Merged
merged 11 commits into from
Nov 19, 2023
Merged

New nrow_subset_linter #2298

merged 11 commits into from
Nov 19, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884

No hits on {lintr}

Will convert some of the TODOs as follow-up issues, I was surprised how many hits this simple version gets already though.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c96d024) 99.38% compared to head (8d5f852) 99.38%.

❗ Current head 8d5f852 differs from pull request most recent head 4bf5bb4. Consider uploading reports for the commit 4bf5bb4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2298   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files         119      119           
  Lines        5392     5392           
=======================================
  Hits         5359     5359           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Collaborator Author

Will convert the TODO to new issues after initial review to satisfy commented_code_linter().

tests/testthat/test-nrow_subset_linter.R Outdated Show resolved Hide resolved
tests/testthat/test-nrow_subset_linter.R Outdated Show resolved Hide resolved
R/nrow_subset_linter.R Outdated Show resolved Hide resolved
R/nrow_subset_linter.R Outdated Show resolved Hide resolved
R/nrow_subset_linter.R Show resolved Hide resolved
inst/lintr/linters.csv Outdated Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

Could use a lot more testing, especially negatives, vectorization and metadata.

AshesITR
AshesITR previously approved these changes Nov 19, 2023
@MichaelChirico MichaelChirico merged commit ff1dc21 into main Nov 19, 2023
20 checks passed
@MichaelChirico MichaelChirico deleted the nrow_subset branch November 19, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants