-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pipe_return_linter #2299
New pipe_return_linter #2299
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 117 117
Lines 5334 5334
=======================================
Hits 5302 5302
Misses 32 32 ☔ View full report in Codecov by Sentry. |
expect_lint(nested_return_lines, NULL, linter) | ||
}) | ||
|
||
test_that("pipe_return_linter blocks simple disallowed usages", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also checked this for lambdas and it works as expected. But I don't think we need to add tests for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by lambdas in this case? |>
? see the comment in the R/ script -- native pipe is excluded because using return() there is a parser error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I meant with purrr's mappers :)
Part of #884
No hits on {lintr}.