Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New consecutive_mutate_linter #2305

Merged
merged 15 commits into from
Nov 21, 2023
Merged

New consecutive_mutate_linter #2305

merged 15 commits into from
Nov 21, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884

No hits on {lintr}

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0815b2a) 99.39% compared to head (01193ab) 99.39%.

❗ Current head 01193ab differs from pull request most recent head 3bbf6a2. Consider uploading reports for the commit 3bbf6a2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2305   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         121      122    +1     
  Lines        5461     5495   +34     
=======================================
+ Hits         5428     5462   +34     
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/consecutive_mutate_linter.R Outdated Show resolved Hide resolved
R/consecutive_mutate_linter.R Outdated Show resolved Hide resolved
inst/lintr/linters.csv Outdated Show resolved Hide resolved
R/consecutive_mutate_linter.R Outdated Show resolved Hide resolved
@@ -0,0 +1,101 @@
#' Force consecutive calls to mutate() into just one when possible
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording could be more consistent to other linters

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@AshesITR AshesITR merged commit a99e7d4 into main Nov 21, 2023
20 checks passed
@AshesITR AshesITR deleted the consecutive_mutate branch November 21, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants