New consecutive_suppression_linter

[MichaelChirico]

Part of #884

No hits on {lintr}

[AshesITR]

I'm wondering whether this would also fit into library_call_linter(). Alternatively, we could lint successive calls to suppressMessages() regardless of their code content. WDYT?

[MichaelChirico]

I'm wondering whether this would also fit into library_call_linter(). Alternatively, we could lint successive calls to suppressMessages() regardless of their code content. WDYT?

We lost some history here, but my memory is we intentionally left out suppress{Warnings,Messages} because of a prevalence of false positives (where suppressWarnings() twice in a row as done "well"). So the idea of subsuming into library_call_linter() SGTM.

[MichaelChirico]

Marking as draft until #2279 is merged

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8414018) 99.39% compared to head (68aaebf) 99.39%.
Report is 1 commits behind head on main.

❗ Current head 68aaebf differs from pull request most recent head e6f282a. Consider uploading reports for the commit e6f282a to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         120      120           
  Lines        5412     5433   +21     
=======================================
+ Hits         5379     5400   +21     
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AshesITR]

Metadata tests and intermingled calls would be interesting to check.

[MichaelChirico]

PTAL at the test in 9977822

[AshesITR]

I was thinking about

suppressMessages()
suppressPackageStartupMessages()
suppressMessages()
suppressPackageStartupMessages()
suppressPackageStartupMessages()

To see how they interact.

[MichaelChirico]

Oh, gotcha. Will add. FWIW, I've never come across this in practice. I assume any author using these consecutive calls is just doing a bunch of copy-paste, rather than thinking carefully about what needs to be suppressed in each case.

[MichaelChirico]

OTOH, there is a lot of R code in the world 😆

https://github.com/proteinphysiologylab/FrustraEvo/blob/044963c1e8016bf957c8fc04043bd75da6e85c4e/Scripts/Generator.R#L2-L7

https://github.com/alematia/MaGplotR/blob/70c3e253635d8ba047038af19b17acc55e87f387/MaGplotR.R#L19-L25