New conjunct_expecation_linter #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hard things in programming... 😆 What comes to mind is |
|
Still a bit too vague (what's being combined?)... |
|
no luck on crowdsourcing I think... conjunct_expectation_linter is still my top choice, WDYT? |
…ntr into expect_true_false_and_condition
MichaelChirico
changed the title
AshesITR
requested changes
Mar 19, 2022
76 tasks
…ntr into expect_true_false_and_condition
AshesITR
requested changes
Mar 19, 2022
…ntr into expect_true_false_and_condition
38 tasks
AshesITR
reviewed
Mar 21, 2022
…ntr into expect_true_false_and_condition
AshesITR
previously approved these changes
Mar 21, 2022
AshesITR
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #884
Here's one where I'm open to suggestions for the name. Has always felt like a mouthful, and doesn't quite pass the test of making it clear/inferrable what the linter does from its name.