Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_vector_s3() #181

Closed
krlmlr opened this issue Mar 20, 2020 · 9 comments · Fixed by #336
Closed

Deprecate is_vector_s3() #181

krlmlr opened this issue Mar 20, 2020 · 9 comments · Fixed by #336
Assignees
@krlmlr
Milestone
1.6.2

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 20, 2020

in favor of vec_is().
@krlmlr krlmlr mentioned this issue Mar 20, 2020
Merged
@krlmlr krlmlr mentioned this issue Jun 14, 2020
Closed
@krlmlr krlmlr added this to the 1.4.5 milestone Jul 8, 2020
@krlmlr
Copy link
Member Author

krlmlr commented Jul 8, 2020

In the next major release.

@krlmlr krlmlr modified the milestones: 1.4.5, 2.0.0, 1.5.0 Jul 8, 2020
@krlmlr
Copy link
Member Author

krlmlr commented Jul 8, 2020

Switch to warning in the next minor release.

@krlmlr krlmlr mentioned this issue Jul 8, 2020
Merged
@anamariaelek anamariaelek mentioned this issue Jul 23, 2020
Closed
@krlmlr krlmlr mentioned this issue Feb 19, 2021
Closed
@krlmlr krlmlr modified the milestones: 1.5.0, 1.5.1 Feb 19, 2021
@krlmlr krlmlr mentioned this issue Feb 19, 2021
Closed
@krlmlr
Copy link
Member Author

krlmlr commented Feb 22, 2021

Need dialr > 0.3.2 to get rid of it entirely.

@krlmlr krlmlr modified the milestones: 1.5.1, 1.5.2 Mar 17, 2021
@krlmlr krlmlr modified the milestones: 1.5.2, 1.6.1 Apr 11, 2021
@krlmlr krlmlr modified the milestones: 1.6.1, 1.6.2 May 24, 2021
@krlmlr
Copy link
Member Author

krlmlr commented May 24, 2021

@gorcha: Are you planning a dialr CRAN release any time soon?

@krlmlr krlmlr self-assigned this May 24, 2021
@gorcha
Copy link

gorcha commented May 24, 2021

Hey @krlmlr, I didn't have one necessarily planned but I can do! I'll try and get an update submitted in the next day or so.

@gorcha
Copy link

gorcha commented May 25, 2021

Hey @krlmlr, new release of dialr is up on CRAN! Let me know if you need anything else.

@krlmlr
Copy link
Member Author

krlmlr commented May 25, 2021 •
edited
Loading

Thanks, that was quick!

Need tidyverse/blob#20 on CRAN.

@gorcha
Copy link

gorcha commented May 26, 2021

No worries! Wasn't far off a release anyway 🙂

@krlmlr krlmlr mentioned this issue Jul 23, 2021
Merged
krlmlr added a commit that referenced this issue Jul 23, 2021
@krlmlr
Merge pull request #336 from r-lib/f-181-is-vector
442b7df 
- `is_vector_s3()` is no longer generic (#181).
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@krlmlr krlmlr

Labels
None yet
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

is_vector_s3() is no longer generic r-lib/pillar
2 participants
@gorcha @krlmlr