-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creation of faulty site #2439
Conversation
@hadley solved. I tripped on the fact that having a default argument the same as the name i.e. f <- function(x = x) {
} creates problem. What is the reason behind that? |
I forget the details, but because default arguments are evaluated when they're used. For example, this is valid R code: f <- function(x = y) {
y <- 10
x
} |
"{.file {pkg$dst_path}} is non-empty and not built by pkgdown", | ||
"!" = "Make sure it contains no important information \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified this error message, but it is almost impossible to get there now unless you really want to!
Thanks! |
Fixes #2329.
Supersedes #2411
Applies the suggestions to call
init_site()
earlier.Will be interesting to see the codecov patch, maybe some messages are no longer reached?
Errors are caused by the fact that
init_site()
is called earlier, which triggers a message.