Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use linting to detect undesired function usage #2541

Merged
merged 9 commits into from
May 16, 2024
Merged

Use linting to detect undesired function usage #2541

merged 9 commits into from
May 16, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented May 13, 2024

No description provided.

@hadley hadley requested review from jayhesselberth and maelle May 13, 2024 22:11
Copy link
Collaborator

@jayhesselberth jayhesselberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice that github links the result at the specific line number.

Copy link
Collaborator

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintr is really great 💎

.lintr.R Show resolved Hide resolved
@hadley
Copy link
Member Author

hadley commented May 14, 2024

I just wish I could figure out why that test is now failing. Has it just been silently failing in the past because dir() would just return character()?

Copy link

github-actions bot commented May 16, 2024

@hadley hadley merged commit 350854a into main May 16, 2024
14 checks passed
@hadley hadley deleted the lintr branch May 16, 2024 14:54
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants