Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the search vignette from navbar and / or transfer doc to ?build_search #2564

Closed
olivroy opened this issue May 21, 2024 · 0 comments · Fixed by #2574
Closed

Remove the search vignette from navbar and / or transfer doc to ?build_search #2564

olivroy opened this issue May 21, 2024 · 0 comments · Fixed by #2574

Comments

@olivroy
Copy link
Collaborator

olivroy commented May 21, 2024

There's little enough in that vignette, I think I'd almost prefer going in the opposite direction — just point to ?build_search from the vignette. (And then maybe remove the vignette from the main navbar since it will only apply to BS3. Or maybe even remove it altogether with a redirect since BS3 is deprecated?)

Originally posted by @hadley in #2562 (comment)

Also, remove mentions to vignette("search") in docs and point to build_search()?

@olivroy olivroy changed the title Remove or empty the search vignette from navbar. Remove the search vignette from navbar and / or transfer doc to ?build_search May 21, 2024
hadley added a commit that referenced this issue May 22, 2024
hadley added a commit that referenced this issue May 23, 2024
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant