Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init_site() doesn't have an override argument #2644

Closed
olivroy opened this issue Jun 6, 2024 · 0 comments · Fixed by #2646
Closed

init_site() doesn't have an override argument #2644

olivroy opened this issue Jun 6, 2024 · 0 comments · Fixed by #2646
Labels
feature a feature request or enhancement

Comments

@olivroy
Copy link
Collaborator

olivroy commented Jun 6, 2024

          Are you sure we shouldn't just call`section_init()` here? I also noticed that `init_site()` lacks `override`, and I needed it when I started experimenting with quarto.

That would make it more consistent with the other functions

Originally posted by @hadley in #2642 (comment)

@olivroy olivroy assigned olivroy and unassigned olivroy Jun 6, 2024
@olivroy olivroy added the feature a feature request or enhancement label Jun 6, 2024
@olivroy olivroy changed the title Add override to init_site() init_site() doesn't have an override argument Jun 6, 2024
hadley added a commit that referenced this issue Jun 7, 2024
* We can figure out `depth` based on whether or not a `subdir` is supplied
* Ensures all user facing functions have the same interface
* Brings together directory checking code in one place

Fixes #2644
hadley added a commit that referenced this issue Jun 7, 2024
* Combine section_init() and create_subdir()

* We can figure out `depth` based on whether or not a `subdir` is supplied
* Ensures all user facing functions have the same interface
* Brings together directory checking code in one place
* Check for files, not directory

Fixes #2644. Closes #2645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
1 participant