Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quarto code with filename (#2776) #2779

Closed
wants to merge 3 commits into from

Conversation

Nenuial
Copy link

@Nenuial Nenuial commented Sep 13, 2024

This is my attempt to implement code with filename in Quarto vignettes.

This would close #2776.

@jacpete
Copy link

jacpete commented Oct 2, 2024

Looks like something in this PR is throwing off the pre tags from getting the correct background color. here is the main branch rendered locally:
image

Vs this PR:
image

@Nenuial
Copy link
Author

Nenuial commented Oct 18, 2024

@jacpete Yes, you are correct. I didn't check this in dark mode, sorry about that.

It took me a while to figure out the exact elements to tweak, but I think it now works with the same colors as the base code blocks.

@jayhesselberth
Copy link
Collaborator

jayhesselberth commented Nov 29, 2024

Thanks for the contribution, but I don't think this will be a heavily used feature, and it makes the link between pkgdown and quarto more tedious.

You can accomplish the same thing by including this in custom CSS in a pkgdown site.

@Nenuial Nenuial deleted the Nenuial/issue2776 branch November 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request in Quarto vignettes: code filenames
3 participants