Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_favicons generates 96x96 but not 16x16 and 32x32 as refrenced in browser #2831

Closed
brandonerose opened this issue Dec 17, 2024 · 1 comment

Comments

@brandonerose
Copy link

brandonerose commented Dec 17, 2024

I was publishing my package and I used usethis::use_logo() and pkgdown::build_favicons() but it appears the API you all use returns a favicon-96x96.png but not 16 and 32 which for me are the ones refrenced in the HTML thats generated in docs.

Screen Shot 2024-12-16 at 6 17 20 PM Screen Shot 2024-12-16 at 6 16 26 PM Screen Shot 2024-12-16 at 6 03 19 PM Screen Shot 2024-12-16 at 6 02 29 PM

My work around was cloning the 96x96 to those other two files but a better fix may be rendering the proper 96 file in the HTML (which I dont know how to do).

# while in the gh-pages branch I just ran this for my fix
file.copy(from = "favicon-96x96.png", to = "favicon-16x16.png")
file.copy(from = "favicon-96x96.png", to = "favicon-32x32.png")
@jayhesselberth
Copy link
Collaborator

This will be fixed in an upcoming release, see #2804.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants