Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stack trace by creating message in separate variable #1975

Closed
wants to merge 1 commit into from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jul 22, 2024

Currently, we get this. This PR will simplify a little the message.

image

@olivroy olivroy changed the title Improve stack trace by wrapping reporter in separate function Improve stack trace by wrapping reporter in separate variable Jul 22, 2024
@olivroy olivroy changed the title Improve stack trace by wrapping reporter in separate variable Improve stack trace by creating message in separate variable Jul 22, 2024
@hadley
Copy link
Member

hadley commented Aug 23, 2024

I think the problem is actually that stop_reporter() uses the error_call argument instead of the call argument. Do you mind fixing that instead? You could also add a snapshot test for stop_reporter() if you wanted.

@olivroy olivroy closed this Aug 23, 2024
@olivroy olivroy deleted the patch-4 branch August 23, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants