Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_active_file() unloads helpers #1982

Closed
hadley opened this issue Aug 23, 2024 · 2 comments · Fixed by #1983
Closed

test_active_file() unloads helpers #1982

hadley opened this issue Aug 23, 2024 · 2 comments · Fixed by #1983
Labels
bug an unexpected problem or unintended behavior tests 📘
Milestone
v3.2.2

Comments

@hadley
Copy link
Member

hadley commented Aug 23, 2024 

devtools::load_all()
devtools::test_active_file("R/active.R")
local_package_create
#> Error: ! object 'local_package_create' not found
@hadley
Copy link
Member Author

hadley commented Aug 23, 2024

Hmmmm, this problem seems to arise from testthat::find_load_all_args() which defaults helpers to FALSE.

@hadley hadley transferred this issue from r-lib/devtools Aug 23, 2024
@hadley
Copy link
Member Author

hadley commented Aug 23, 2024

Hmmm, this seems like an unintended consequence of #1841

hadley added a commit that referenced this issue Aug 23, 2024
@hadley
Rely on load_all() to load helpers
4dee774 
Otherwise effectively unload them for the developer. Fixes #1982
@hadley hadley mentioned this issue Aug 23, 2024
Merged
@hadley hadley added bug an unexpected problem or unintended behavior tests 📘 labels Oct 22, 2024
@hadley hadley added this to the v3.2.2 milestone Oct 22, 2024
hadley added a commit that referenced this issue Oct 23, 2024
@hadley
Rely on load_all() to load helpers (#1983)
75c70e0 
Otherwise effectively unload them for the developer. Fixes #1982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior tests 📘
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging a pull request may close this issue.

Rely on load_all() to load helpers r-lib/testthat
1 participant
@hadley