-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to confirm that the pop node is running after pop up parachain
command
#117
Comments
Is this open for public contributors? I would love to work on this enhancement |
Absolutely, go ahead! We're thrilled to see the community contributing to improve If you need any help or have questions, please let us know here, or feel free to join our Telegram group.: https://t.me/Pop_Network |
@chungquantin I am removing the label enhancement from this and adding discussion. I want the community to discuss whether this should be an added feature to pop-cli or not. If voted yes you can begin working on it. I will also keep you in mind for other features. cc: @AlexD10S |
I like the idea of opening a browser with Polkadot-Js for the local node. Maybe a |
Personally, I think it should not pop up the browser automatically. After running |
The interactivity makes sense to me. This feature would be specific to the case where the user specifies the pop-node e.g.
These option could be helpful if the user wants to bypass the interactive question. @AlexD10S any thoughts? |
I like the idea of interactivity too! and if the user wants open the browser automatically is a cool feature. The main difficult for this task is to get the port where the parachain we want to open is running. It has to be parsed here: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/src/commands/up/parachain.rs#L79 from the type the |
Hi 👋, first let me say that the cli looks awesome! Thanks!! |
Just a general FYI: we want to add an additional The initial use case is funding the dev accounts on PopNet via Xcm from relay (PopNet uses relay token) but this could be used by anyone to run any additional command/script as required. Keeping this in mind might be useful in considering the eventual UX selected. |
I found a CLI tool called Substrate Manager: https://github.com/omerdn1/substrate-manager which build the interactive flow very clean. Put it here as a reference. |
I don't believe we were aware of that at all, so thank you very much for sharing! |
As a user, I would like for a browser window to open with Pop Network upon successful completion of the command:
So that I do not have to manually open a browser window to confirm that Pop Network is running.
The text was updated successfully, but these errors were encountered: