Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api/nonfungibles): fork pallet nfts #382

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

chungquantin
Copy link
Collaborator

Description

Fork of pallet-nfts v1.15.0 for the implementation of pallet-api/non-fungibles: #339.

Only changes I made is the Cargo.toml to update it consistent with other pallets.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 57.81341% with 1447 lines in your changes missing coverage. Please review.

Project coverage is 68.38%. Comparing base (3cdb9b5) to head (b9fe4d8).

Files with missing lines Patch % Lines
pallets/nfts/src/weights.rs 1.86% 736 Missing ⚠️
pallets/nfts/src/impl_nonfungibles.rs 22.06% 266 Missing and 6 partials ⚠️
pallets/nfts/src/lib.rs 71.82% 53 Missing and 78 partials ⚠️
pallets/nfts/src/migration.rs 0.00% 53 Missing ⚠️
pallets/nfts/src/types.rs 67.11% 49 Missing ⚠️
pallets/nfts/src/features/attributes.rs 86.36% 19 Missing and 23 partials ⚠️
pallets/nfts/src/benchmarking.rs 85.79% 11 Missing and 14 partials ⚠️
pallets/nfts/src/features/transfer.rs 83.84% 9 Missing and 12 partials ⚠️
pallets/nfts/src/features/create_delete_item.rs 89.20% 5 Missing and 14 partials ⚠️
pallets/nfts/src/features/metadata.rs 91.56% 0 Missing and 14 partials ⚠️
... and 9 more
@@             Coverage Diff             @@
##             main     #382       +/-   ##
===========================================
+ Coverage   54.34%   68.38%   +14.03%     
===========================================
  Files          49       70       +21     
  Lines        5025    11846     +6821     
  Branches     5025    11846     +6821     
===========================================
+ Hits         2731     8101     +5370     
- Misses       2245     3486     +1241     
- Partials       49      259      +210     
Files with missing lines Coverage Δ
pallets/nfts/src/mock.rs 100.00% <100.00%> (ø)
pallets/nfts/src/tests.rs 99.88% <ø> (ø)
pallets/nfts/src/features/roles.rs 96.15% <96.15%> (ø)
pallets/nfts/src/features/approvals.rs 93.25% <93.25%> (ø)
pallets/nfts/src/common_functions.rs 80.00% <80.00%> (ø)
pallets/nfts/src/features/buy_sell.rs 90.69% <90.69%> (ø)
pallets/nfts/src/features/lock.rs 90.12% <90.12%> (ø)
pallets/nfts/src/features/settings.rs 84.41% <84.41%> (ø)
pallets/nfts/src/features/atomic_swap.rs 90.51% <90.51%> (ø)
...lets/nfts/src/features/create_delete_collection.rs 84.33% <84.33%> (ø)
... and 11 more

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It caused a bit of confusion that you added v1.15 while pop node is on 1.14.

I compared the changes made from v1.14 and stable, and only sp-std has been replaced for alloc which is the case here as well and won't cause an issue.

Left a few nitpicks but the rest is all good!

pallets/nfts/Cargo.toml Outdated Show resolved Hide resolved
pallets/nfts/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffed with v1.15 and the only changes are the manifests and then source code formatting.

Only required change for me is attribution - setting the authors correctly.

pallets/nfts/Cargo.toml Outdated Show resolved Hide resolved
pallets/nfts/Cargo.toml Outdated Show resolved Hide resolved
pallets/nfts/runtime-api/Cargo.toml Outdated Show resolved Hide resolved
pallets/nfts/runtime-api/Cargo.toml Outdated Show resolved Hide resolved
@chungquantin chungquantin requested review from evilrobot-01 and removed request for evilrobot-01 November 18, 2024 08:41
@evilrobot-01 evilrobot-01 merged commit aff6408 into main Nov 18, 2024
13 checks passed
@evilrobot-01 evilrobot-01 deleted the chungquantin/chore-fork_pallet_nfts branch November 18, 2024 09:05
@chungquantin chungquantin linked an issue Nov 19, 2024 that may be closed by this pull request
20 tasks
chungquantin added a commit that referenced this pull request Nov 19, 2024
chungquantin added a commit that referenced this pull request Nov 19, 2024
chungquantin added a commit that referenced this pull request Nov 19, 2024
chungquantin added a commit that referenced this pull request Nov 21, 2024
chungquantin added a commit that referenced this pull request Nov 21, 2024
chungquantin added a commit that referenced this pull request Nov 22, 2024
chungquantin added a commit that referenced this pull request Nov 22, 2024
chungquantin added a commit that referenced this pull request Nov 22, 2024
chungquantin added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(pop-api): nonfungibles use case
5 participants