From 3d19fd013c164c02b8eab21cad9c1f545f6278da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Raymond=20Aug=C3=A9?= <raymond.auge@liferay.com>
Date: Tue, 5 Oct 2021 15:53:57 -0400
Subject: [PATCH] OSGi import/export headers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- <developers><developer><id> element added to silence a complaint from bnd about well formed entries
- let bnd generate default manifest spec entries, as well as setting all other headers
- added BND SPI annotations to add the necessary parts to make ServiceLoader work in OSGi (passively)

fixes #242

Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
---
 .gitignore                                    |  5 ++
 pom.xml                                       | 54 ++++++++++++++++---
 r2dbc-spi-test/pom.xml                        | 14 ++---
 r2dbc-spi/pom.xml                             | 21 +++++---
 .../r2dbc/spi/ConnectionFactoryProvider.java  |  7 +++
 5 files changed, 78 insertions(+), 23 deletions(-)

diff --git a/.gitignore b/.gitignore
index 79f736d..fd996a1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,6 +9,11 @@ dependency-reduced-pom.xml
 buildNumber.properties
 .mvn/timing.properties
 
+# Eclipse
+.project
+.classpath
+.settings
+
 # IntelliJ
 out/
 build/
diff --git a/pom.xml b/pom.xml
index 698aedf..5a6c254 100644
--- a/pom.xml
+++ b/pom.xml
@@ -41,6 +41,9 @@
         <jsr305.version>3.0.2</jsr305.version>
         <junit.version>5.7.0</junit.version>
         <assertj.version>3.17.2</assertj.version>
+        <bnd.version>6.0.0</bnd.version>
+        <osgi.annotation.version>8.0.0</osgi.annotation.version>
+        <project.build.outputTimestamp>1</project.build.outputTimestamp>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <reactive-streams.version>1.0.3</reactive-streams.version>
@@ -62,18 +65,22 @@
 
     <developers>
         <developer>
+            <id>nebhale</id>
             <name>Ben Hale</name>
             <email>bhale@pivotal.io</email>
         </developer>
         <developer>
+            <id>mp911de</id>
             <name>Mark Paluch</name>
             <email>mpaluch@vmware.com</email>
         </developer>
         <developer>
+            <id>mirromutth</id>
             <name>Mirro Mutth</name>
             <email>mirromutth@gmail.com</email>
         </developer>
         <developer>
+            <id>gregturn</id>
             <name>Greg Turnquist</name>
             <email>gturnquist@pivotal.io</email>
         </developer>
@@ -106,6 +113,46 @@
     <build>
         <pluginManagement>
             <plugins>
+                <plugin>
+                    <groupId>biz.aQute.bnd</groupId>
+                    <artifactId>bnd-maven-plugin</artifactId>
+                    <version>${bnd.version}</version>
+                    <executions>
+                        <execution>
+                            <goals>
+                                <goal>bnd-process</goal>
+                            </goals>
+                        </execution>
+                    </executions>
+                    <configuration>
+                        <bnd><![CDATA[
+                            # Vars are ignored from the output
+                            spec.version = ${version;===;${project.version}}
+
+                            Automatic-Module-Name: ${replacestring;${project.artifactId};-;.}
+
+                            # Don't import findbugs annotation packages since they are never runtime dependency
+                            Import-Package:\
+                                 !javax.annotation.*,\
+                                 *
+
+                            R2DBC-Specification-Version: ${project.version}
+
+                            # Automatically export all packages in the resulting jar at spec version
+                            -exportcontents: *;version=${spec.version}
+
+                            # Add default specification headers
+                            -namesection: io/r2dbc/spi*/;\
+                                Specification-Title="${project.name}";\
+                                Specification-Version="${spec.version}"
+
+                            # Ensure repeatable builds if desired
+                            -noextraheaders: true
+                            -snapshot: SNAPSHOT
+                        ]]></bnd>
+                        <skipIfEmpty>true</skipIfEmpty>
+                    </configuration>
+                </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-compiler-plugin</artifactId>
@@ -129,12 +176,7 @@
                     <version>3.2.0</version>
                     <configuration>
                         <archive>
-                            <manifest>
-                                <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
-                            </manifest>
-                            <manifestEntries>
-                                <R2DBC-Specification-Version>${project.version}</R2DBC-Specification-Version>
-                            </manifestEntries>
+                            <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
                         </archive>
                     </configuration>
                 </plugin>
diff --git a/r2dbc-spi-test/pom.xml b/r2dbc-spi-test/pom.xml
index e0c3469..5fb1ed2 100644
--- a/r2dbc-spi-test/pom.xml
+++ b/r2dbc-spi-test/pom.xml
@@ -77,6 +77,10 @@
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>biz.aQute.bnd</groupId>
+                <artifactId>bnd-maven-plugin</artifactId>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
@@ -84,16 +88,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>
-                        <manifest>
-                            <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
-                        </manifest>
-                        <manifestEntries>
-                            <Automatic-Module-Name>r2dbc.spi.test</Automatic-Module-Name>
-                        </manifestEntries>
-                    </archive>
-                </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
diff --git a/r2dbc-spi/pom.xml b/r2dbc-spi/pom.xml
index d63f58b..7824e2d 100644
--- a/r2dbc-spi/pom.xml
+++ b/r2dbc-spi/pom.xml
@@ -39,6 +39,16 @@
             <artifactId>reactive-streams</artifactId>
             <version>${reactive-streams.version}</version>
         </dependency>
+        <dependency>
+            <groupId>biz.aQute.bnd</groupId>
+            <artifactId>biz.aQute.bnd.annotation</artifactId>
+            <version>${bnd.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.osgi</groupId>
+            <artifactId>osgi.annotation</artifactId>
+            <version>${osgi.annotation.version}</version>
+        </dependency>
         <dependency>
             <groupId>com.google.code.findbugs</groupId>
             <artifactId>jsr305</artifactId>
@@ -63,6 +73,10 @@
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>biz.aQute.bnd</groupId>
+                <artifactId>bnd-maven-plugin</artifactId>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
@@ -70,13 +84,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>
-                        <manifestEntries>
-                            <Automatic-Module-Name>r2dbc.spi</Automatic-Module-Name>
-                        </manifestEntries>
-                    </archive>
-                </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
diff --git a/r2dbc-spi/src/main/java/io/r2dbc/spi/ConnectionFactoryProvider.java b/r2dbc-spi/src/main/java/io/r2dbc/spi/ConnectionFactoryProvider.java
index 6a3dc89..c21a72e 100644
--- a/r2dbc-spi/src/main/java/io/r2dbc/spi/ConnectionFactoryProvider.java
+++ b/r2dbc-spi/src/main/java/io/r2dbc/spi/ConnectionFactoryProvider.java
@@ -16,8 +16,13 @@
 
 package io.r2dbc.spi;
 
+import static aQute.bnd.annotation.Cardinality.MULTIPLE;
+import static aQute.bnd.annotation.Resolution.OPTIONAL;
+
 import java.util.ServiceLoader;
 
+import aQute.bnd.annotation.spi.ServiceConsumer;
+
 /**
  * A Java Service interface for implementations to examine a collection of {@link ConnectionFactoryOptions} and optionally return an implementation of {@link ConnectionFactory}.
  * <p>{@link ConnectionFactoryProvider} implementations are typically discovered by {@link ConnectionFactories} from the class path using {@link ServiceLoader}.
@@ -27,6 +32,8 @@
  * @see ConnectionFactories
  * @see ServiceLoader
  */
+@ServiceConsumer(cardinality = MULTIPLE, effective = "active", value = ConnectionFactoryProvider.class)
+@ServiceConsumer(cardinality = MULTIPLE, resolution = OPTIONAL, value = ConnectionFactoryProvider.class)
 public interface ConnectionFactoryProvider {
 
     /**