81 feature sub alerts #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twitch subscriptions (including re-subscription, gift and community subscriptions) will now create custom chat messages that will be dispatched to the message bus. Other agents may collect such events so that they can act upon such events.
DistributedCommandRegistryAdapter was removed from ExecutorAgent as it was no longer used. This simplifies the code and improves readability and maintainability.
Implemented a filter condition in the OnNotificationReceived method of the CommandParsingAgent class. This change ensures that only chat message notifications are processed. Previously all events were accepted, leading to possible unintended behaviour. Now non-chat messages are logged and ignored, enhancing performance and control.
Implemented Twitch Alert feature, which includes separate Agent and Core projects. The Core project contains the fundamental logic and entities for handling Twitch Alerts, while the Agent is responsible for running the listener service. The listener service targets specific chat message events and potentially responds to them. Message count filtering is updated to only count actual chat messages. Also added an upsert method in LiteDb and MongoDB repositories for more straightforward data updates. Code structure in FloppyBot.sln has been amended for better organization. Docker image for Twitch Alerts has been included in the automated build and release workflow. This addition will provide more detailed and efficient alert handling for Twitch events.
Closed
Moved the methods 'DetermineTemplate', 'GetTier', and 'ParseTwitchEvent' above instance variables in TwitchAlertListener for better code readability and cohesion. No behavior changes were made, just improving the organization and structure of the code.
Updated the TwitchAlertSettings and the TwitchAlertListener to allow for easier message customization. In TwitchAlertSettings, default values for the optional messages were added to avoid potential null reference issues. For the TwitchAlertListener, added logic for formatting alert messages with user's display name before sending the chat message. This change allows for a more personalized alert message. Also, created a new file for Command `subalert` to set, clear, or reset the alert message. In addition, a reference to FloppyBot.Base.Extensions have been added to both projects `FloppyBot.Aux.TwitchAlerts.Core.csproj` and `FloppyBot.Commands.Aux.Twitch.csproj` to make use of the newly created ObjectExtensions for a more efficient retrieval of properties. This overall modification provides streamers with the ability to customize the alert message when someone subscribes, enhancing user interaction and experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.