Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not catching statSync errors #23

Open
adzyu100 opened this issue Aug 14, 2020 · 1 comment
Open

Not catching statSync errors #23

adzyu100 opened this issue Aug 14, 2020 · 1 comment

Comments

@adzyu100
Copy link

Hi,

If statSync errors out, it doesn't get handled and stored in the err object, but instead just gets raised and stops the entire function. This can be easily reproduced by just passing in a path to a wav file that doesn't actually exist. This can probably be fixed by just surrounding the statSync call with a try/catch block to catch these errors. Thanks!

@drj-io
Copy link
Member

drj-io commented Sep 1, 2020

Hi @adzyu100 would you be interested in submitting a pull request? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants