Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a uuid (uuid4) as marker #470

Open
realtimeprojects opened this issue Apr 26, 2024 · 3 comments · May be fixed by #476
Open

Consider using a uuid (uuid4) as marker #470

realtimeprojects opened this issue Apr 26, 2024 · 3 comments · May be fixed by #476

Comments

@realtimeprojects
Copy link
Contributor

At this time the marker is derived from the epoch time. However, especially when running tests on different hosts in parallel, there is a chance that two seperate test runs might get the same marker. This violates the rules for certain regulatory requirements. Hence, we should use a uuid as a marker to eliminate this problem.

@fliiiix
Copy link
Member

fliiiix commented Apr 26, 2024

Im very interested in how you use markers and i guess you are already aware that you are in control of the marker?

I guess one can easily provide a custom maker which is just a uuid something like this ->

radish SomeFeature.feature -m uuid

@realtimeprojects
Copy link
Contributor Author

In regulated environments, you have to be able to uniquely identify your testrun for documentation purposes. As far as I understood the documentation, this is the purpose of the marker. However, in my opinion, the current implementation does not serve this purpose very well, since there is a (small) chance that two different testruns produce the same marker, when started at the same time. A uuid would serve this purpose much better.

Yes, I am aware that I can control the marker from outside, so this is no big issue for me, but I was thinking this might be a good improvement for radish itself.

@fliiiix fliiiix linked a pull request Nov 23, 2024 that will close this issue
@fliiiix
Copy link
Member

fliiiix commented Nov 23, 2024

@realtimeprojects please take a look at the open MR if that is the thing you had in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants