fix: Correct type definitions for createElement function

rafaucau · Sep 22, 2023 · a61fbc5 · a61fbc5
1 parent f77abf8
commit a61fbc5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ts-dom-utils",
-  "version": "2.0.1",
+  "version": "2.1.0",
   "description": "A simple utility library for DOM manipulation. Provides TypeScript typings for enhanced development experience in TS environments.",
   "main": "dist/index.cjs",
   "module": "dist/index.js",

diff --git a/src/createElement.ts b/src/createElement.ts
@@ -22,7 +22,8 @@
  */
 export default function createElement<K extends keyof HTMLElementTagNameMap>(
   tagName: K,
-  options: CreateElementOptions = {},
+  options: Partial<Omit<HTMLElementTagNameMap[K], keyof SpecialAttributes>> &
+    SpecialAttributes = {},
   target = document,
 ): HTMLElementTagNameMap[K] {
   const element = target.createElement(tagName);
@@ -50,16 +51,19 @@ export default function createElement<K extends keyof HTMLElementTagNameMap>(
       return;
     }
 
+    if (key in element) {
+      (element as any)[key] = value;
+      return;
+    }
+
     element.setAttribute(key, value as string);
   });
 
   return element;
 }
 
-// FIXME try to use string type instead of any
-export type CreateElementOptions = {
-  [key: string]: any;
-  class?: string | string[];
-  dataset?: Record<string, string>;
-  text?: string;
-};
+export type SpecialAttributes = Partial<{
+  class: string | string[];
+  dataset: Record<string, string>;
+  text: string;
+}>;