Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicating adaptive_wait with the server-client setup #20

Open
HomerW opened this issue Oct 23, 2023 · 0 comments
Open

Replicating adaptive_wait with the server-client setup #20

HomerW opened this issue Oct 23, 2023 · 0 comments
Assignees

Comments

@HomerW
Copy link
Contributor

HomerW commented Oct 23, 2023

Blocking control with the new server-client setup should exactly match blocking control in the old setup. However, for non-blocking control we still need to replicate the functionality of adaptive_wait from the old setup. The adaptive_wait function waits to trigger the call to get the observation such that the observation is returned approximately after the full step duration has passed. Thus, it calls curent_obs() at current_time + step_duration - time_to_get_obs where time_to_get_obs is measured empirically as the time it takes to get the image from the camera (0.08 seconds). In eval.py, we're calling curent_obs() at current_time + step_duration which will return an image from later than in the old setup. If we want to fix this, we should probably add a function in the eval script that waits for the right amount of time before calling widowx_client.get_observation().

Low-priority since all our provided checkpoints are intended to be evaluated with blocking control.

@youliangtan youliangtan self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants