Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainbow setting wrong currency for payment link #4475

Closed
RonanKMcGovern opened this issue Dec 12, 2022 · 14 comments
Closed

Rainbow setting wrong currency for payment link #4475

RonanKMcGovern opened this issue Dec 12, 2022 · 14 comments
Labels

Comments

@RonanKMcGovern
Copy link

Rainbow is approving an ETH payment when it should be approving a 10 USDC payment. (This is not happening with any other wallet).

Payment link: https://www.trelis.com/payment/94987a45-589d-4e32-8ee2-e7fda94c4703

I'm showing screenshots of the approvals that Coinbase Wallet (10 USDC, correct) and Rainbow (10 ETH, completely incorrect) show for this same payment link.
Uploading Coinbase.jpeg…

@RonanKMcGovern
Copy link
Author

anyone else seeing an issue like this?

@juscamarena
Copy link

I see the same using wagmi setting at transfer event with an erc20 contract. Weird.

@juscamarena
Copy link

Screenshot 2022-12-20 at 5 39 21 PM

Screenshot 2022-12-20 at 5 39 32 PM

Sending a normal ETH transactions shows as an 'ETH request'

I sent a USDT transfer, which shows as a transfer, but as if it's sending ETH as well, oddly. @RonanKMcGovern

@RonanKMcGovern
Copy link
Author

Yup, thanks @juscamarena . I think this is a pretty major bug. If you're trying to send 2 USDC and you accidentally send 2 ETH, that's a pretty big issue.

@DanielSinclair bringing this to your attention. Happening via wagmi, whether using walletconnect to connect Rainbow or using Rainbowkit to connect Rainbow wallet.

@DanielSinclair
Copy link
Contributor

@RonanKMcGovern Thanks for bringing this to our attention. Was able to replicate the issue and it appears to solely be a display issue for Transfer requests. The underlying transaction values aren't impacted; here's a test transaction. Buy a coffee on us! Escalated to the team to rollout a bug fix.

@RonanKMcGovern
Copy link
Author

Thanks! Appreciate it. I'll let you close this out once done. Thanks also @juscamarena for replicating

@github-actions
Copy link

Stale issue message

@buildtheui
Copy link

Hi there, I wanted to re-open this conversation, it's been three months since this bug was reported but I still see this problem, for both android and ios, thanks

@rgrchen
Copy link

rgrchen commented Mar 21, 2023

+1. Would be amazing if this could be fixed soon. We have a use case where users can purchase products with Rainbow, but if a 10 USDC price displays as 10 ETH, then no one will complete the transaction. Many thanks.

@juscamarena
Copy link

I see the same with walletconnect on iOS when requesting a token payment.

@github-actions
Copy link

Stale issue message

@juscamarena
Copy link

juscamarena commented Jul 24, 2023

The issue still shows with walletconnect 2 requesting an erc20 payment. The correct currency is not displayed say if requesting on the polygon network, requesting 20 USDC shows as 20 MATIC.

We want to enable walletconnect payments for stablecoins but can't if users use rainbow as they'd be confused why the currency is not shown correctly.

@skylarbarrera
Copy link
Contributor

He!

this was fixed in the last release of the mobile app

sorry for the wait and thanks for everybody's patience 🙏

🌈

@juscamarena
Copy link

Thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants