Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: enable + analytics #5074

Merged
merged 18 commits into from
Oct 13, 2023
Merged

i18n: enable + analytics #5074

merged 18 commits into from
Oct 13, 2023

Conversation

skylarbarrera
Copy link
Contributor

@skylarbarrera skylarbarrera commented Sep 25, 2023 •
edited
Loading

What changed (plus any additional context for devs)

enabled i18n and adds tracking

Screen recordings / screenshots

What to test

@skylarbarrera skylarbarrera marked this pull request as ready for review September 28, 2023 17:32
ibrahimtaveras00
ibrahimtaveras00 requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://linear.app/rainbow/issue/APP-822/i18n-qa-bug-epic

@ibrahimtaveras00
Copy link
Contributor

Still a few outstanding issues, not sure if you want to count any of these as blockers or not for merging:

@DanielSinclair
i18n: translation updates, thai, korean, arabic, datetime locale (#5111)
e9a2aa3 
* chore: translation updates

* feat: add arabic, thai, korean

* feat: korean, thai, arabic language

* fix: locale date switch
ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outside of missing French translations, everything else was good 👍🏽

@skylarbarrera skylarbarrera merged commit 922ab6b into develop Oct 13, 2023
4 of 5 checks passed
@skylarbarrera skylarbarrera deleted the @skylar/turn-on-i18n branch October 13, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@benisgold benisgold benisgold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skylarbarrera @ibrahimtaveras00 @benisgold @DanielSinclair