Remove deprecated InstallListener in Android manifest which is causing a ClassNotFoundException crash for Android users #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a ClassNotFound exception
APP-851 Android Crashlytics crash: ClassNotFoundException on branch InstallListener
Android had deprecated the InstallListener a while back so branch has recommended removing this from the Android manifest. If you look at their latest documentation, it does not include the receiver. Context for solution: https://github.com/BranchMetrics/react-native-branch-deep-linking-attribution/issues/539 What to test: confirm that deeplinking is still behaving as expected Additional info: https://android-developers.googleblog.com/2019/11/still-using-installbroadcast-switch-to.html https://developer.android.com/google/play/installreferrer/library |
jinchung
requested review from
dereknelson,
benisgold,
ibrahimtaveras00 and
walmat
and removed request for
dereknelson and
benisgold
skylarbarrera
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-851
Additional context in Linear ticket.
What to test: deeplinking still working as expected