Fix provider recursion bug, provider function types #5829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
Jun 8, 2024
greg-schrammel
approved these changes
Jun 9, 2024
BrodyHughes
added a commit
that referenced
this pull request
Jun 11, 2024
…ap-v2-e2e * 'develop' of github.com:rainbow-me/rainbow: Fix weird issues with rounding (#5822) Fix provider recursion bug, provider function types (#5829) bump braces (#5831) Add entry point for other networks (#5824) remove info icon on max transaction fee row as we don't have that in spec (#5827) [e2e] Add Malicious Dapp interaction test (#5764) reorg ens related calls (#5828) Performance: limit Sentry tracking, fix NFT hooks (#5819) fix wrong chainname (#5823) Disable flashbots toggle on appropriate chains (#5812) add type to SearchAsset type and add into type possibilities (#5820) fix fasterimage border radius android (#5816) more Safemath fixes (#5818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1567
What changed (plus any additional context for devs)
getProviderForNetworkwas being repeatedly called throughout the app, for every network, due to thegetProviderfunction within the network objects being invoked any timegetNetworkObjorgetXNetworkObjwas invokedgetProviderForNetworkwas called for a not-yet-cached network, the calling ofgetNetworkObjfrom withingetProviderForNetworkwould then again callgetProviderForNetworkdue togetProviderwithin the network object being invoked, leading to a recursive loop that would run until the provider eventually made it into the cachegetProviderForNetworkandgetCachedProviderForNetworkfunctionsgetIsHardhatConnectedhelper functionScreen recordings / screenshots
What to test