Revert "Revert "Brody/swap v2 e2e (#5915)" (#5987)" #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
BrodyHughes
force-pushed
the
brody/fixed-swap-e2e
branch
from
2de2228 to
93e645b
Compare
walmat
reviewed
Aug 8, 2024
|
@BrodyHughes conflicts 😭 |
walmat
reviewed
Aug 21, 2024
walmat
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to add this e2e messed up CI and caused it to loop forever bc of an error in the animation configs. I noticed this after it was merged unfortunately bc of weird timing with some other PRs it happened to pass.
That issue is fixed here: ef118ec
The test was also failing bc of an issue with fetching hardhat balances and them not being set properly in userAssets. changes made in
userAssetsQueryFunctionnow return hardhat assets correctly in the correct format and changes insetUserAssetsmake it more flexible in handling Maps and Arrays and checking bothnative.balance.amountandbalance.amount.Those changes are here: 9009796