Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix improper to address for ERC-20 sends #6052

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fix improper to address for ERC-20 sends #6052

merged 1 commit into from
Aug 29, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Aug 28, 2024

Fixes APP-1823
Fixes #5678

What changed (plus any additional context for devs)

  • pulls ERC-20 to address from change direction === 'out' for meta.type === 'send'

Screen recordings / screenshots

What to test

@linear Linear
Copy link

linear bot commented Aug 28, 2024

APP-1823 ERC20 transfers show contract address instead of recipient as payment destination

@walmat walmat requested review from welps, derHowie and benisgold August 28, 2024 18:12
@walmat walmat merged commit 1552bf9 into develop Aug 29, 2024
5 checks passed
@walmat walmat deleted the @matthew/fix-wrong-address-for-sends branch August 29, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welps welps welps approved these changes

@derHowie derHowie Awaiting requested review from derHowie

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC20 transfers show contract address instead of recipient as payment destination
2 participants
@walmat @welps