Fix crash due to failed estimated gas limit #6055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Aug 30, 2024
| } catch (e) { | ||
| return String(quote?.defaultGasLimit) || String(default_estimate); | ||
| return quote?.defaultGasLimit || default_estimate; |
There was a problem hiding this comment.
my guess was this was causing an issue with the string case on quote?.defaultGasLimit when undefined
walmat
commented
Aug 30, 2024
| @@ -71,7 +69,14 @@ export const estimateUnlockAndCrosschainSwap = async ({ | |||
| quote, | |||
| }); | |||
|
|
|||
| if (swapGasLimit === null || swapGasLimit === undefined || isNaN(Number(swapGasLimit))) { | |||
| return null; | |||
There was a problem hiding this comment.
this will bubble up to the estimation and use the basic_swap defaults for the chain
walmat
commented
Aug 30, 2024
| const gasLimit = gasLimits.concat(swapGasLimit).reduce((acc, limit) => add(acc, limit), '0'); | ||
| if (isNaN(Number(gasLimit))) { | ||
| return null; |
walmat
commented
Aug 30, 2024
| @@ -85,7 +80,14 @@ export const estimateUnlockAndSwap = async ({ | |||
| quote, | |||
| }); | |||
|
|
|||
| if (swapGasLimit === null || swapGasLimit === undefined || isNaN(Number(swapGasLimit))) { | |||
| return null; | |||
walmat
commented
Aug 30, 2024
| const gasLimit = gasLimits.concat(swapGasLimit).reduce((acc, limit) => add(acc, limit), '0'); | ||
| if (isNaN(Number(gasLimit))) { | ||
| return null; |
benisgold
approved these changes
Sep 4, 2024
src/__swaps__/screens/Swap/providers/SyncSwapStateAndSharedValues.tsx
Outdated
Show resolved
Hide resolved
brunobar79
requested review from
estebanmino
and removed request for
brunobar79
walmat
commented
Sep 10, 2024
estebanmino
approved these changes
Sep 12, 2024
ibrahimtaveras00
added a commit
that referenced
this pull request
Sep 20, 2024
This reverts commit 56e9585.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1819
What changed (plus any additional context for devs)
Biggest change here is adding
NaNchecks throughout raps so we don't receive an invalid gas limit. I also removed a suspiciously problematicString()cast which I presume was causing a lot of the issues. https://github.com/rainbow-me/rainbow/pull/6055/files#r1739045385This could've been returning
undefinedbut then cast to astringwhich would've been problematic later on in the flow.Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-10.at.14.08.11.mp4
What to test