Swaps v2 cleanup duplicates / unused utils #6202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
changed the title
There was a problem hiding this comment.
helpers/utilities is a funny name lmao
There was a problem hiding this comment.
wdyt of removing the Worklet suffix? since worklet functions work in both runtimes, we can consolidate it all in single functions, rn we have two functions for the same thing in multiple cases
not for this pr, just what do you think?
greg-schrammel
approved these changes
Oct 17, 2024
jinchung
pushed a commit
that referenced
this pull request
Oct 31, 2024
* start on ripping out old swaps * Update package.json * clean up lint * add pbx? * tslint is a liar * fixed it * rm graph * revert changes to pbx * Swaps v2 cleanup duplicates / unused utils (#6202) * remove bunch of duplicate utils * remove unused hooks and remove duplicate AnimatedBlurView * remove multiple getUniqueIds and only keep worklet version * reorder worklets * remove getCrosschainSwapServiceTime from handlers/swap * remove ExchangeSearch * remove unused NetworkSwitcher components * rename useFeePanelInputRefs to useFeesPanelInputRefs * remove swapSearch and walletFilter * delete unused useMinRefuelAmount hook * delete unused exchangeModalTypes file * remove unused selectUserAssetsListByChainId selector * change getAddressAndChainIdFromUniqueId to work for both networks and chains * remove duplicate buildLocalizedTimeUnitString util * remove duplicate buildLocalizedTimeUnitString util * remove TokenSelectionButton * remove SendFab * replace a couple accessors to native assets that could be sync * remove unused fromChainId from useSearchCurrencyList * remove unused isCrosschainSearch from useSearchCurrencyList * bring back navigation hook that prevents readOnly wallets from navigating to buy, send, and swaps * clean up crossChainServiceTime and remove traces * add swaps v2 comment * fix initial asset missing on expanded state navigation (#6240) * fix gas button stuck on loading (#6241) * fix gas button issues? * rm poll causing infinite loop * remove some weird checks * maybe? * move unused vars to swaps util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
All of the shared / unused utils for swaps got moved into the already existing version or deleted.
@/__swaps__/utils/numbers->@/helpers/utilities@/__swaps__/screens/Swap/components/AnimatedBlurView->
@/components/AnimatedComponents/AnimatedBlurView@/__swaps__/utils/ethereum->@/parsers@/__swaps__/utils/hex->@/handlers/web3@/__swaps__/utils/strings->@/utils@/__swaps__/utils/address->@/utils/ethereumUtils@/__swaps__/utils/chains->@/handlers/assetsAny swaps function that was unused by anything I went ahead and deleted.
Condensed
@/__swaps__/utils/time->@/__swaps__/utils/gasUtils.tssince we only needed one function in that file and it was only used in gas related stuff.Remove unused hooks
useAssetsToBuy,useAssetsToSell,useAssets,There were multiple functions handling deriving uniqueId from asset address and chainId, so I condensed those into one place. And there was also multiple uniqueId builders, which now we only have one.
Also, I moved
safe-mathinto the TLD. Didn't move other swaps files as that should be done in another PR in order to keep this one as small as possible.Screen recordings / screenshots
What to test
test critical paths from swaps, sends, etc.