completing a swap navigates back to previous screen #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-schrammel
commented
Oct 16, 2024
| @@ -129,6 +129,7 @@ function setTopLevelNavigator(navigatorRef) { | |||
|
|
|||
There was a problem hiding this comment.
vote to migrate this to ts since Im here
walmat
reviewed
Oct 16, 2024
walmat
approved these changes
Oct 16, 2024
benisgold
approved these changes
Oct 16, 2024
Co-authored-by: Matthew Wall <[email protected]>
greg-schrammel
deleted the
gregs/app-1810-after-completing-a-swap-navigate-to-the-screen-user-was
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
edge case if the users previous screen was an Expanded Sheet, navigate to the Wallet Screen instead of back to the Expanded Sheet
Screen recordings / screens
pow
Screen.Recording.2024-10-16.at.03.54.26.mov
What to test