bump positions query persister version #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
Oct 31, 2024
benisgold
approved these changes
Oct 31, 2024
greg-schrammel
deleted the
gregs/app-1971-nan-while-loading-wallet-balance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
when removing moxie locked positions from the total wallet balance I introduced a new
positions.totals.totalLockedthat theuseWalletBalancessubtract from the total, when the user has old persisted data this prop does not exist while it's refetching/reparsing the positions, making it try to subtract undefined and returning NaNinstead of bumping the persister version (which may cause the user to have the wrong balance, without any positions value, for a couple seconds while it refetches it for the first time after this change is released)
we could do like
positions.totals.totalLocked || '0'defensive style but Ithinkin this case I like to have and keep the type contract, not a strong opinion thoScreen recordings / screenshots
What to test