Added automatic donate buttons #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdomegg
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Sorry for the delay reviewing this.
Overall this looks good, and I'm excited to not have to manually add all the buttons each year! This will increase load on the backend but I think this is an okay trade-off: we can always come back and review this if my AWS bill shoots up 😅
Two minor pieces of feedback:
- I think the logic could be slightly clearer - I've demonstrated this for the alumni page here: be8f86a
- When changing the indentation of a lot of code (e.g. 3000 lines - if it was e.g. 30 lines it'd be fine) it can be challenging for a reviewer to figure out the important lines that have changed. In future if making similar changes it'd be helpful to separate out the indentation change to a separate commit, because then the reviewer can see the actual changes separately more easily. Nothing to change for this PR, just hopefully useful feedback for you in future :)
Next steps: Could you apply similar changes to (1) in the other pages? After that I'll get this merged! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #378
Added donate buttons to each chapter's page, which are now dependant on whether their fundraiser is 'running' (based on Proposed solution: option B). As a result, when a chapter's fundraiser is still 'running', it will display the donation buttons on their page, and should not display the donation buttons when the fundraiser is no longer 'running'.
This feature was also added to the alumni, demo and workplace pages too.